fix gremlin job result size gt cassandra limit and lt hugegraph limit #1334
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Change-Id: Iade74c66259214a6895ae369374c7243761cb0e0
javeme
requested changes
Jan 14, 2021
| private static final String ERROR_MAX_LEN = "Failed to commit changes: " + | ||
| "The max length of bytes is"; | ||
| private static final String ERROR_COMMIT = "Failed to commit changes: "; | ||
| private static final String ERROR_MAX_LEN = "The max length of bytes is"; |
| /* | ||
| * ERROR_TOO_LARGE_BATCH occurs when using cassandra store | ||
| * and result size is in | ||
| * [batch_size_fail_threshold_in_kb, TASK_RESULT_SIZE_LIMIT) |
Codecov Report
@@ Coverage Diff @@
## master #1334 +/- ##
============================================
- Coverage 62.32% 62.31% -0.01%
- Complexity 5770 5772 +2
============================================
Files 377 377
Lines 31553 31564 +11
Branches 4422 4423 +1
============================================
+ Hits 19666 19670 +4
- Misses 9887 9894 +7
Partials 2000 2000
Continue to review full report at Codecov.
|
javeme
reviewed
Jan 14, 2021
| @@ -117,6 +126,15 @@ protected void save() { | |||
| } | |||
| } | |||
|
|
|||
| private static boolean needSaveWithEx(String message) { | |||
javeme
approved these changes
Jan 14, 2021
|
|
Linary
approved these changes
Jan 14, 2021
javeme
pushed a commit
that referenced
this pull request
Feb 10, 2021
…#1334) Change-Id: Ic2a246facffca683052bb56bf76ad21b5413d94a
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Change-Id: Iade74c66259214a6895ae369374c7243761cb0e0