Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Minor: add editorconfig #1904

Merged
merged 2 commits into from
Jun 24, 2022
Merged

Minor: add editorconfig #1904

merged 2 commits into from
Jun 24, 2022

Conversation

jackwener
Copy link
Member

It's a small but useful change.

It's will enable new_line in end which is good for code-style.

set end_of_line = lf is useful to the developers using Windows.

.editorconfig Outdated

[*.{java,xml,py}]
indent_style = space
indent_size = 4
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

add a new line in the end of file, and When and where will this file take effect? (only in win or some IDE?)

Copy link
Member Author

@jackwener jackwener Jun 16, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

https://editorconfig.org/

editorconfig just works in almost IDE(vsc, IDEA.....) .

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ok, seems fine

should we add more options? @seagle-yuan

@codecov
Copy link

codecov bot commented Jun 16, 2022

Codecov Report

Merging #1904 (592e088) into master (dadbc7b) will decrease coverage by 4.29%.
The diff coverage is n/a.

@@             Coverage Diff              @@
##             master    #1904      +/-   ##
============================================
- Coverage     70.46%   66.16%   -4.30%     
- Complexity      962      964       +2     
============================================
  Files           452      452              
  Lines         38778    38778              
  Branches       5527     5527              
============================================
- Hits          27324    25658    -1666     
- Misses         8775    10604    +1829     
+ Partials       2679     2516     -163     
Impacted Files Coverage Δ
...hugegraph/backend/store/raft/RaftStoreClosure.java 0.00% <0.00%> (-100.00%) ⬇️
...ugegraph/backend/store/rocksdb/RocksDBMetrics.java 0.00% <0.00%> (-85.87%) ⬇️
...gegraph/backend/store/rocksdb/RocksDBFeatures.java 4.16% <0.00%> (-83.34%) ⬇️
...baidu/hugegraph/backend/store/raft/RaftResult.java 0.00% <0.00%> (-81.25%) ⬇️
...aidu/hugegraph/backend/store/raft/RaftContext.java 0.00% <0.00%> (-80.96%) ⬇️
...hugegraph/backend/store/raft/RaftBackendStore.java 0.00% <0.00%> (-75.27%) ⬇️
...hugegraph/backend/store/raft/rpc/RpcForwarder.java 0.00% <0.00%> (-69.50%) ⬇️
.../backend/store/raft/rpc/StoreCommandProcessor.java 0.00% <0.00%> (-65.22%) ⬇️
...ugegraph/backend/store/raft/StoreStateMachine.java 0.00% <0.00%> (-64.87%) ⬇️
...h/backend/store/raft/RaftBackendStoreProvider.java 0.00% <0.00%> (-61.33%) ⬇️
... and 45 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update dadbc7b...592e088. Read the comment docs.

javeme
javeme previously approved these changes Jun 21, 2022
Copy link
Contributor

@javeme javeme left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Thanks for your contribution

.editorconfig Outdated Show resolved Hide resolved
@javeme javeme merged commit 3328964 into apache:master Jun 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants