-
Notifications
You must be signed in to change notification settings - Fork 527
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Minor: add editorconfig #1904
Minor: add editorconfig #1904
Conversation
.editorconfig
Outdated
|
||
[*.{java,xml,py}] | ||
indent_style = space | ||
indent_size = 4 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
add a new line in the end of file, and When and where will this file take effect? (only in win or some IDE?)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
editorconfig
just works in almost IDE(vsc, IDEA.....) .
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
ok, seems fine
should we add more options? @seagle-yuan
Codecov Report
@@ Coverage Diff @@
## master #1904 +/- ##
============================================
- Coverage 70.46% 66.16% -4.30%
- Complexity 962 964 +2
============================================
Files 452 452
Lines 38778 38778
Branches 5527 5527
============================================
- Hits 27324 25658 -1666
- Misses 8775 10604 +1829
+ Partials 2679 2516 -163
Continue to review full report at Codecov.
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM! Thanks for your contribution
It's a small but useful change.
It's will enable
new_line in end
which is good forcode-style
.set
end_of_line = lf
is useful to the developers using Windows.