Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(api): clean some code for release #2348

Merged
merged 2 commits into from
Nov 13, 2023
Merged

fix(api): clean some code for release #2348

merged 2 commits into from
Nov 13, 2023

Conversation

imbajin
Copy link
Member

@imbajin imbajin commented Nov 13, 2023

Purpose of the PR

Main Changes

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • xxx

Does this PR potentially affect the following parts?

  • Nope
  • Dependencies (add/update license info)
  • Modify configurations
  • The public API
  • Other affects (typed here)

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need

@imbajin imbajin added this to the 1.2.0 milestone Nov 13, 2023
Copy link

codecov bot commented Nov 13, 2023

Codecov Report

Merging #2348 (626103f) into master (bce6d05) will increase coverage by 0.49%.
The diff coverage is 68.75%.

@@             Coverage Diff              @@
##             master    #2348      +/-   ##
============================================
+ Coverage     64.44%   64.93%   +0.49%     
- Complexity      979      983       +4     
============================================
  Files           507      507              
  Lines         42084    42083       -1     
  Branches       5832     5832              
============================================
+ Hits          27121    27328     +207     
+ Misses        12275    12066     -209     
- Partials       2688     2689       +1     
Files Coverage Δ
.../apache/hugegraph/backend/tx/GraphTransaction.java 79.37% <100.00%> (+0.98%) ⬆️
...g/apache/hugegraph/structure/HugeEdgeProperty.java 68.42% <100.00%> (ø)
...g/apache/hugegraph/type/define/CollectionType.java 61.11% <ø> (ø)
...ugegraph/backend/store/mysql/ResultSetWrapper.java 62.50% <ø> (ø)
...aph/traversal/optimize/HugePrimaryKeyStrategy.java 85.71% <71.42%> (+0.34%) ⬆️
...n/java/org/apache/hugegraph/api/auth/LoginAPI.java 72.72% <40.00%> (-1.56%) ⬇️

... and 24 files with indirect coverage changes

📣 Codecov offers a browser extension for seamless coverage viewing on GitHub. Try it in Chrome or Firefox today!

@imbajin imbajin merged commit a7ad7ea into master Nov 13, 2023
@imbajin imbajin deleted the code-clean branch November 13, 2023 04:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants