fix(chore): remove zgc in dockerfile for ARM env #2421
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dosubot
bot
added
size:XS
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2421 +/- ##
============================================
- Coverage 66.32% 66.24% -0.09%
Complexity 828 828
============================================
Files 511 511
Lines 42596 42596
Branches 5942 5942
============================================
- Hits 28253 28216 -37
- Misses 11547 11568 +21
- Partials 2796 2812 +16 ☔ View full report in Codecov by Sentry. |
imbajin
reviewed
Jan 19, 2024
imbajin
changed the title
Co-authored-by: imbajin <jin@apache.org>
imbajin
previously approved these changes
Jan 22, 2024
dosubot
bot
added
size:M
aroundabout
commented
Jan 22, 2024
| cp "${CONF}/${GREMLIN_SERVER_CONF}" "${BAK_CONF}/${GREMLIN_SERVER_CONF}.bak" | ||
| cp "${CONF}/${REST_SERVER_CONF}" "${BAK_CONF}/${REST_SERVER_CONF}.bak" | ||
| cp "${CONF}/graphs/${GRAPH_CONF}" "${BAK_CONF}/${GRAPH_CONF}.bak" | ||
| if [ ! -d "$BAK_CONF" ]; then |
There was a problem hiding this comment.
new test image is pushed as dandelionivy/server
imbajin
reviewed
Jan 23, 2024
hugegraph-server/Dockerfile
Outdated
| @@ -24,12 +24,13 @@ WORKDIR /pkg | |||
| ARG MAVEN_ARGS | |||
|
|
|||
| RUN mvn package $MAVEN_ARGS -e -B -ntp -DskipTests -Dmaven.javadoc.skip=true && pwd && ls -l | |||
| RUN find . -name 'apache-hugegraph-incubating-*.tar.gz' -delete | |||
imbajin
reviewed
Jan 23, 2024
hugegraph-server/Dockerfile
Outdated
|
|
||
| # 2nd stage: runtime env | ||
| # remove zgc, which is only available on ARM-Mac with java > 13 |
There was a problem hiding this comment.
seems the comment line could be better ↓
imbajin
reviewed
Jan 23, 2024
imbajin
reviewed
Jan 23, 2024
hugegraph-server/Dockerfile
Outdated
| && apt-get clean \ | ||
| && rm -rf /var/lib/apt/lists/* | ||
| && rm -rf /var/lib/apt/lists/* \ | ||
| && service cron start | ||
|
|
||
| # 2. Init HugeGraph Sever |
There was a problem hiding this comment.
maybe step2 could also be merged into st1?
imbajin
previously approved these changes
Jan 24, 2024
There was a problem hiding this comment.
I'll try it soon & update the doc PR apache/incubator-hugegraph-doc#324
Update: test it fine with auth-mode now
imbajin
reviewed
Jan 24, 2024
imbajin
approved these changes
Jan 24, 2024
aroundabout
added a commit
to aroundabout/incubator-hugegraph
that referenced
this pull request
Jan 26, 2024
* remove zgc * Apply suggestions from code review Co-authored-by: imbajin <jin@apache.org> * add comment for hugegraph-server.sh * fix enable-auth.sh * init store in entrypoint * use flag file to skip re-init * delete tar.gz * simply dockerfile * mvn optimize * simply dockerfile * add init log in docker --------- Co-authored-by: imbajin <jin@apache.org>
11 tasks
imbajin
added a commit
that referenced
this pull request
Jan 29, 2024
* remove zgc * Apply suggestions from code review * add comment for hugegraph-server.sh * fix enable-auth.sh * init store in entrypoint * use flag file to skip re-init * delete tar.gz * simply dockerfile * mvn optimize * simply dockerfile * add init log in docker --------- Co-authored-by: imbajin <jin@apache.org>
VGalaxies
pushed a commit
that referenced
this pull request
Jan 29, 2024
* remove zgc * Apply suggestions from code review Co-authored-by: imbajin <jin@apache.org> * add comment for hugegraph-server.sh * fix enable-auth.sh * init store in entrypoint * use flag file to skip re-init * delete tar.gz * simply dockerfile * mvn optimize * simply dockerfile * add init log in docker --------- Co-authored-by: imbajin <jin@apache.org>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose of the PR
On macos(ARM arch M1/2/3..), zgc is only available with java > 13, so we remove -g zgc in the docker-entrypoint.sh.
Todo
Main Changes
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODODoc - DoneDoc - No Need