-
Notifications
You must be signed in to change notification settings - Fork 529
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: migrate the hg-style.xml
to .editorconfig
#2561
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2561 +/- ##
============================================
- Coverage 56.89% 4.92% -51.98%
+ Complexity 827 479 -348
============================================
Files 612 590 -22
Lines 49672 47154 -2518
Branches 6681 6233 -448
============================================
- Hits 28261 2321 -25940
- Misses 18603 44646 +26043
+ Partials 2808 187 -2621 ☔ View full report in Codecov by Sentry. |
Signed-off-by: Frosty <112929809+FrostyHec@users.noreply.github.com> test
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks fine~ Thanks for your contribution
PS: Do u test it in the IDEA env?
Thanks~, I have test some cases in IDEA and use the checkstyle in project for verification. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM~
hg-style.xml
to .editorconfig
Purpose of the PR
Migrate the format defined in hg-style.xml to editorconfig for code style controlling. Editorconfig offers enhanced capabilities for defining coding conventions and can be automatically recognized and imported by IDEA.
Main Changes
Removed hugegraph-style.xml and define the code format control in editorconfig with same functionality.
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need