Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: migrate the hg-style.xml to .editorconfig #2561

Merged
merged 1 commit into from
Jun 28, 2024

Conversation

FrostyHec
Copy link
Contributor

Purpose of the PR

Migrate the format defined in hg-style.xml to editorconfig for code style controlling. Editorconfig offers enhanced capabilities for defining coding conventions and can be automatically recognized and imported by IDEA.

Main Changes

Removed hugegraph-style.xml and define the code format control in editorconfig with same functionality.

Verifying these changes

  • Trivial rework / code cleanup without any test coverage. (No Need)
  • Already covered by existing tests, such as (please modify tests here).
  • Need tests and can be verified as follows:
    • After pulling the latest editorconfig file, restart IDEA and check if files is formated as expected. We can also open the editorconfig file and use the "Preview Code Style" for verification, as shown below:

image

Does this PR potentially affect the following parts?

Documentation Status

  • Doc - TODO
  • Doc - Done
  • Doc - No Need
    • The file format configuration is enabled by default

@dosubot dosubot bot added the size:L This PR changes 100-499 lines, ignoring generated files. label Jun 22, 2024
Copy link

codecov bot commented Jun 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 4.92%. Comparing base (1e97521) to head (34385c7).
Report is 1 commits behind head on master.

Current head 34385c7 differs from pull request most recent head f65d056

Please upload reports for the commit f65d056 to get more accurate results.

❗ There is a different number of reports uploaded between BASE (1e97521) and HEAD (34385c7). Click for more details.

HEAD has 5 uploads less than BASE | Flag | BASE (1e97521) | HEAD (34385c7) | |------|------|------| ||7|2|
Additional details and impacted files
@@             Coverage Diff              @@
##             master   #2561       +/-   ##
============================================
- Coverage     56.89%   4.92%   -51.98%     
+ Complexity      827     479      -348     
============================================
  Files           612     590       -22     
  Lines         49672   47154     -2518     
  Branches       6681    6233      -448     
============================================
- Hits          28261    2321    -25940     
- Misses        18603   44646    +26043     
+ Partials       2808     187     -2621     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Signed-off-by: Frosty <112929809+FrostyHec@users.noreply.github.com>

test
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks fine~ Thanks for your contribution

PS: Do u test it in the IDEA env?

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jun 25, 2024
@FrostyHec
Copy link
Contributor Author

Looks fine~ Thanks for your contribution

PS: Do u test it in the IDEA env?

Thanks~, I have test some cases in IDEA and use the checkstyle in project for verification.

Copy link
Contributor

@VGalaxies VGalaxies left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM~

@VGalaxies VGalaxies changed the title Migrating the hg-style.xml to.editorconfig chore: migrate the hg-style.xml to .editorconfig Jun 28, 2024
@VGalaxies VGalaxies merged commit 37e71c4 into apache:master Jun 28, 2024
14 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Migrate the hg-style.xml to.editorconfig
3 participants