Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: minor improve for pom properties #2574

Merged
merged 6 commits into from
Jul 15, 2024
Merged

chore: minor improve for pom properties #2574

merged 6 commits into from
Jul 15, 2024

Conversation

VGalaxies
Copy link
Contributor

@VGalaxies VGalaxies commented Jul 10, 2024 •
edited
Loading

As title.

This was referenced Jul 10, 2024
Open
Closed
@codecov Codecov
Copy link

codecov bot commented Jul 10, 2024 •
edited
Loading

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 53.77%. Comparing base (cedc000) to head (351b5eb).

Additional details and impacted files 
@@             Coverage Diff              @@
##             master    #2574      +/-   ##
============================================
+ Coverage     52.47%   53.77%   +1.29%     
- Complexity      586      751     +165     
============================================
  Files           643      643              
  Lines         53387    53356      -31     
  Branches       7018     7017       -1     
============================================
+ Hits          28017    28694     +677     
+ Misses        22541    21784     -757     
- Partials       2829     2878      +49

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@VGalaxies VGalaxies marked this pull request as ready for review July 10, 2024 15:01
@VGalaxies VGalaxies requested a review from imbajin July 10, 2024 15:01
@dosubot dosubot bot added size:L This PR changes 100-499 lines, ignoring generated files. ci-cd Build or deploy dependencies Incompatible dependencies of package labels Jul 10, 2024
imbajin
imbajin previously approved these changes Jul 11, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

THX, LGTM

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 11, 2024
@imbajin imbajin requested review from zyxxoo and liuxiaocs7 July 11, 2024 07:36
@VGalaxies VGalaxies requested a review from imbajin July 13, 2024 09:36
@imbajin
Copy link
Member

imbajin commented Jul 15, 2024

Should warn the PG-CI always failed now:

image

@imbajin imbajin merged commit bd83741 into master Jul 15, 2024
15 of 17 checks passed
@imbajin imbajin deleted the pom-chore branch July 15, 2024 06:59
@VGalaxies VGalaxies mentioned this pull request Jul 15, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@JackyYangPassion JackyYangPassion JackyYangPassion approved these changes

@imbajin imbajin imbajin approved these changes

@zyxxoo zyxxoo Awaiting requested review from zyxxoo

@liuxiaocs7 liuxiaocs7 Awaiting requested review from liuxiaocs7

Assignees
No one assigned
Labels
ci-cd Build or deploy dependencies Incompatible dependencies of package lgtm This PR has been approved by a maintainer size:L This PR changes 100-499 lines, ignoring generated files.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@VGalaxies @imbajin @JackyYangPassion