Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

refact(pd): remove redundant property in LogMeta & PartitionMeta #2598

Merged
merged 3 commits into from
Aug 2, 2024
Merged

refact(pd): remove redundant property in LogMeta & PartitionMeta #2598

merged 3 commits into from
Aug 2, 2024

Conversation

haohao0103
Copy link
Contributor

close #2597

@dosubot dosubot bot added size:XS This PR changes 0-9 lines, ignoring generated files. pd PD module labels Jul 19, 2024
@imbajin imbajin requested a review from VGalaxies July 22, 2024 15:49
imbajin
imbajin reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@imbajin imbajin left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this need to be optimized in version 1.5? Pay attention to the diff increase in subsequent versions

@VGalaxies
Copy link
Contributor

Does this need to be optimized in version 1.5? Pay attention to the diff increase in subsequent versions

I think it is possible, although it will bring some diffs.

@imbajin
Copy link
Member

imbajin commented Jul 23, 2024

Does this need to be optimized in version 1.5? Pay attention to the diff increase in subsequent versions

I think it is possible, although it will bring some diffs.

OK, could merge it after #2599

@dosubot dosubot bot added the lgtm This PR has been approved by a maintainer label Jul 31, 2024
@imbajin imbajin changed the title refact(pd): fix pdconfig property in LogMeta and PartitionMeta is redundant refact(pd): remove redundant property in LogMeta & PartitionMeta Aug 2, 2024
@imbajin imbajin merged commit 3427f42 into apache:master Aug 2, 2024
14 of 15 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@imbajin imbajin imbajin approved these changes

@JackyYangPassion JackyYangPassion JackyYangPassion approved these changes

@VGalaxies VGalaxies Awaiting requested review from VGalaxies

Assignees
No one assigned
Labels
lgtm This PR has been approved by a maintainer pd PD module size:XS This PR changes 0-9 lines, ignoring generated files.
Projects
HugeGraph PD-Store Tasks
Status: Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[refact] The pdconfig property in LogMeta and PartitionMeta is redundant
4 participants
@haohao0103 @VGalaxies @imbajin @JackyYangPassion