-
Notifications
You must be signed in to change notification settings - Fork 528
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
refactor: centralize version management in all modules #2722
base: master
Are you sure you want to change the base?
Conversation
- Improved version management by introducing Maven's property - Replaced hardcoded version strings with dynamic retrieval - Added version.properties to support runtime version access - Ensured updated version in scripts and classes
@lavanyavijayk There is an issue with the version number here for compilation error, it should be updated to |
I also want to get more details for the following. The ticket mentions a change in /hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/version/ApiVersion.java, but it is unclear which string should be replaced with the revision value. Could you confirm this before proceeding? |
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #2722 +/- ##
============================================
- Coverage 46.81% 40.36% -6.46%
+ Complexity 1049 611 -438
============================================
Files 754 754
Lines 60327 60328 +1
Branches 7691 7691
============================================
- Hits 28244 24349 -3895
- Misses 29265 33423 +4158
+ Partials 2818 2556 -262 ☔ View full report in Codecov by Sentry. |
Purpose of the PR
This PR centralizes version management across the project by leveraging Maven's ${revision} property and a filtered version.properties file for dynamic runtime access to the version. It removes the need for hardcoded version strings and ensures consistent versioning across all modules.
Main Changes
Need More Clarity on
file path - /hugegraph-server/hugegraph-api/src/main/java/org/apache/hugegraph/version/ApiVersion.java had a change mentioned in the ticket but not sure which string needs to be replaced with the revision value. need confirmation to go ahead and make the change.
##Working On
Attempted to update CoreVersion.DEFAULT_VERSION(file path - /hugegraph-server/hugegraph-core/src/main/java/org/apache/hugegraph/version/CoreVersion.java) to dynamically use the revision value, but encountered an error during compilation, so the change is not yet applied.
Verifying these changes
Does this PR potentially affect the following parts?
Documentation Status
Doc - TODO
Doc - Done
Doc - No Need