Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Support pagination when single index query #328

Merged
merged 8 commits into from
Mar 27, 2019
Merged

Support pagination when single index query #328

merged 8 commits into from
Mar 27, 2019

Conversation

Linary
Copy link
Contributor

@Linary Linary commented Jan 9, 2019

implement: #215 #287
Change-Id: I15c10c702078ff4a998378633e5cbb68cf2ac5fa

@Linary Linary force-pushed the index-page branch 14 times, most recently from 404ab02 to 6a800ec Compare January 14, 2019 14:32
@Linary Linary force-pushed the index-page branch 16 times, most recently from 80f8714 to 992b3fe Compare January 19, 2019 14:07
Change-Id: I06369fc3ab8e4ce52b9c68ac8c343d2bfea79a9d
Change-Id: I81470bc43276bc195ede4cb7320042cefb1ff6f3
Change-Id: Ib52121bcda96002048c826012929863f204f8c12
Change-Id: I70a0ac73a1641bdb1a71d30b3ce366fe3c593178
zhoney
zhoney previously requested changes Mar 18, 2019
}

@Test
public void testQueryByUnionIndexInPageWithSomeIndexNoData() {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

JointIndex

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It's not joint index, but multi indexes' result union

Change-Id: If9709dd1fb8e584630c48db01edd2ce99b65636b
@Linary Linary requested review from javeme and zhoney March 23, 2019 03:42
@Linary Linary dismissed stale reviews from javeme and zhoney March 25, 2019 06:01

done

javeme
javeme previously approved these changes Mar 27, 2019
Change-Id: Iba5c32d39de390374a5492c8c15089c0f530a16a
@zhoney zhoney merged commit c50c34a into master Mar 27, 2019
@zhoney zhoney deleted the index-page branch March 27, 2019 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants