Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

support negative number for index #513

Merged
merged 3 commits into from
Jun 4, 2019
Merged

support negative number for index #513

merged 3 commits into from
Jun 4, 2019

Conversation

javeme
Copy link
Contributor

@javeme javeme commented May 15, 2019

Change-Id: I7067cfb0a663e89ae4305425edf00e6a2a03587c
implement: #311

@codecov
Copy link

codecov bot commented May 22, 2019

Codecov Report

Merging #513 into master will increase coverage by 0.09%.
The diff coverage is 88.88%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #513      +/-   ##
============================================
+ Coverage     70.09%   70.18%   +0.09%     
- Complexity     3410     3415       +5     
============================================
  Files           216      216              
  Lines         16503    16448      -55     
  Branches       2360     2350      -10     
============================================
- Hits          11567    11544      -23     
+ Misses         3678     3649      -29     
+ Partials       1258     1255       -3
Impacted Files Coverage Δ Complexity Δ
...idu/hugegraph/backend/store/hbase/HbaseTables.java 85% <ø> (+25.35%) 0 <0> (ø) ⬇️
...aph/backend/store/postgresql/PostgresqlTables.java 91.37% <100%> (ø) 1 <0> (ø) ⬇️
...hugegraph/backend/serializer/BinarySerializer.java 80.1% <100%> (ø) 102 <0> (ø) ⬇️
...aidu/hugegraph/backend/store/mysql/MysqlTable.java 76.76% <100%> (+0.31%) 70 <4> (+1) ⬆️
...idu/hugegraph/backend/store/mysql/MysqlTables.java 86.86% <100%> (ø) 1 <0> (ø) ⬇️
...java/com/baidu/hugegraph/type/define/DataType.java 89.85% <66.66%> (-2.69%) 36 <0> (+2)
...gegraph/backend/store/memory/InMemoryDBTables.java 75.84% <87.5%> (-2.58%) 0 <0> (ø)
...du/hugegraph/backend/tx/GraphIndexTransaction.java 79.52% <0%> (-0.32%) 146% <0%> (+1%)
...m/baidu/hugegraph/backend/tx/GraphTransaction.java 82.26% <0%> (+0.14%) 209% <0%> (+1%) ⬆️
... and 2 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update abebfac...c0685fd. Read the comment docs.

@javeme javeme force-pushed the neg-index branch 27 times, most recently from f2d142a to acba4ab Compare May 30, 2019 07:14
@@ -557,8 +498,21 @@ public RangeIndex() {
boolean keyMinEq) {
NavigableMap<Id, BackendEntry> rs = this.store();

E.checkArgument(!(keyMin == null && keyMax == null),
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

seems keyMin != null || keyMax != null more readable

javeme added 3 commits June 3, 2019 17:11
Change-Id: I7067cfb0a663e89ae4305425edf00e6a2a03587c
implement: #311
Change-Id: Ie4f7af7083628b44f605944a014a2e5443d4767d
Change-Id: I5ee00eab8808d2f0a447346cac785764369670b9
@Linary Linary merged commit f3a3c35 into master Jun 4, 2019
@Linary Linary deleted the neg-index branch June 4, 2019 02:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants