Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DROOLS-7576] Add benchmarks for secondary super cache issue #270

Merged
merged 2 commits into from
Oct 24, 2023

Conversation

tkobayas
Copy link
Contributor

  • ConcurrentUpdateRightTupleBenchmark calls RightTupleImpl.getTupleSink() a lot
  • ConcurrentUpdateLeftTupleBenchmark calls LeftTuple.getTupleSink() a lot

- ConcurrentUpdateRightTupleBenchmark calls RightTupleImpl.getTupleSink() a lot
- ConcurrentUpdateLeftTupleBenchmark calls LeftTuple.getTupleSink() a lot
@tkobayas
Copy link
Contributor Author

GHA failed because of

2023-10-24T05:16:39.2535562Z [ERROR] Failed to execute goal on project drools-benchmarks-reliability: Could not resolve dependencies for project org.drools:drools-benchmarks-reliability:jar:1.0-SNAPSHOT: Could not find artifact org.drools:drools-reliability-h2mvstore:jar:8.45.0-SNAPSHOT in apache-public-repository-group (https://repository.apache.org/content/groups/public/) -> [Help 1]

but drools-reliability-h2mvstore:jar:8.45.0-SNAPSHOT exists in jboss repo.
https://repository.jboss.org/nexus/content/groups/public/org/drools/drools-reliability-h2mvstore/8.45.0-SNAPSHOT/

Do you have any ideas why it fails? @hellowdan @pibizza

@tkobayas
Copy link
Contributor Author

Anyway, the GHA error is not related to this PR. @lucamolteni , Can you try on your end?

@tkobayas tkobayas requested a review from lucamolteni October 24, 2023 06:16
@lucamolteni
Copy link
Contributor

Anyway, the GHA error is not related to this PR. @lucamolteni , Can you try on your end?

I've tried on my machine and it works properly, I'm not sure why CI gives an error on drools-reliability-h2mvstore:jar

@hellowdan
Copy link
Contributor

Hi @tkobayas, I was able to run this benchamark locally as well. I'll ask someone from CI for their opinion.

@mariofusco
Copy link
Contributor

@hellowdan can we merge this or is it better to wait for CI to be fixed?

@hellowdan
Copy link
Contributor

Hi @mariofusco I think we can merge it since I was also able to run it from our internal QE automation.

@mariofusco mariofusco merged commit 25381b9 into apache:main Oct 24, 2023
0 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants