-
Notifications
You must be signed in to change notification settings - Fork 1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Don't fail a range comparison in FEEL when a unary test range is used #1744
Comments
range_010 Those 3 tests are failing in 0068 suite test. |
After deeper investigation, it turns out that there are different problems related to this ticket. 1
So, first of all I think there is an issue in the InfixOpNode/EqExecutor, that, in this case, should verify if the expression is the same, and not if its evaluation is the same.
2 Problem 2 could be solved implementing conversion of would still be there because, during execution, left and right side would be evaluated to same object before comparison. |
I made modification in my own branch, and I have fixed some use cases. Expression Currently, the expression is converted to With my modification, |
There is a DMN TCK failure, when running with Drools:
[ERROR] 0068-feel-equality-test-01.range_010 – Time elapsed: 0.016 s <<< ERROR!
java.lang.RuntimeException: ERROR: FAILURE: 'range_010' expected='false' but found='null'
The test is located here (1). Based on the error, it looks like the engine fails the evaluation on an exception somewhere. It should behave based on the definition in the test and return false.
Options how to debug:
Replicating the test case directly in Drools repository, so it gets a proper stack trace pointing to the code path being executed, to be able to see the code areas, which may need a fix. If the test case is mainly just a FEEL expression (FEEL is a language used to write expressions in DMN), the FEEL expression could be added to a test class, e.g. this one (2), so it can be run in isolation.
(1) https://github.com/dmn-tck/tck/blob/master/TestCases/compliance-level-3/0068-feel-equality/0068-feel-equality.dmn#L1311
(2) https://github.com/apache/incubator-kie-drools/blob/16897949cb6b691ec6b919cd4593288ebbd00cee/kie-dmn/kie-dmn-feel/src/test/java/org/kie/dmn/feel/runtime/FEELRangesTest.java#L36
The text was updated successfully, but these errors were encountered: