Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1744] Don't fail a range comparison in FEEL when a unary test range is used #6231

Merged
merged 3 commits into from
Jan 27, 2025

Conversation

gitgabrio
Copy link
Contributor

Fixes apache/incubator-kie-issues#1744

This PR:

  1. implement conversion of equal unary test to range (e.g. =10 -> [10 ..10]]
  2. disable one test that currently break with the new implementation, due to apparent unconsistence of DMN specs/implementation
  3. add a test to verify unarytest/range comparison

This is the diff of TCK test before and after this PR:

main

"compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_010","ERROR","FAILURE: 'range_010' expected='false' but found='null'"
"compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_011","ERROR","FAILURE: 'range_011' expected='true' but found='null'"

PR
< "compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_010","ERROR","FAILURE: 'range_010' expected='false' but found='true'"
< "compliance-level-3/0068-feel-equality","0068-feel-equality-test-01","range_011","SUCCESS",""

As discussed in issue, some tests seems to compare the syntax, and not the actual value, so those won't be fixed by this PR.

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@gitgabrio gitgabrio requested review from baldimir and yesamer January 24, 2025 17:04
@yesamer yesamer merged commit ffc421a into apache:main Jan 27, 2025
10 checks passed
@yesamer yesamer added the DMN label Jan 27, 2025
@gitgabrio gitgabrio deleted the incubator-kie-issues#1744 branch January 27, 2025 08:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Don't fail a range comparison in FEEL when a unary test range is used
3 participants