Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

SimpleDateFormat synchronization issue #32

Closed
wants to merge 1 commit into from
Closed

SimpleDateFormat synchronization issue #32

wants to merge 1 commit into from

Conversation

zenix
Copy link
Contributor

@zenix zenix commented Jun 18, 2011

SimpleDateFormat is not thread safe. Synchronized access to it if using static.

@triceo
Copy link
Contributor

triceo commented Jun 19, 2011

Please consider pulling this into 5.2.x as well.

@etirelli
Copy link
Contributor

Geoffrey, since we have to release in a few hours, I will push this pull request as is. We can later tune this if necessary.

@etirelli etirelli closed this Jun 21, 2011
dupliaka pushed a commit to dupliaka/drools that referenced this pull request Apr 1, 2022
@mswiderski
add missing pom.xml configuration to meet release rules for repository (
e0803fa 
apache#32)
tkobayas added a commit to tkobayas/drools that referenced this pull request Dec 8, 2023
@tkobayas
[DROOLS-7540] Coercion from Interger literal to BigDecimal bind varia…
249fa70 
…ble (apache#32)

- Test cases
tkobayas added a commit to tkobayas/drools that referenced this pull request Dec 12, 2023
@github-actions @tkobayas
[7.67.x] [DROOLS-7540] Coercion from Interger literal to BigDecimal b…
6268069 
…ind variable (apache#33)

* [DROOLS-7540] Coercion from Interger literal to BigDecimal bind variable (apache#32)

- Test cases

* remove wrong backport

---------

Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
tkobayas added a commit to tkobayas/drools that referenced this pull request Dec 12, 2023
@github-actions @tkobayas
[7.67.x-blue] [DROOLS-7540] Coercion from Interger literal to BigDeci…
e716f71 
…mal bind variable (apache#34)

* [DROOLS-7540] Coercion from Interger literal to BigDecimal bind variable (apache#32)

- Test cases

* remove wrong backport

---------

Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>
tkobayas added a commit to tkobayas/drools that referenced this pull request Dec 12, 2023
@tkobayas
[DROOLS-7540] Coercion from Interger literal to BigDecimal bind varia…
10c4c9d 
…ble (apache#32)

- Bump mvel to 2.5.1.Final
- Test cases
@tkobayas tkobayas mentioned this pull request Dec 12, 2023
Merged
mariofusco pushed a commit that referenced this pull request Dec 14, 2023
@tkobayas
[DROOLS-7540] Coercion from Interger literal to BigDecimal bind varia…
b30e331 
…ble (#32) (#5622)

- Bump mvel to 2.5.1.Final
- Test cases
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Jan 16, 2024
@tkobayas @rgdoliveira
[DROOLS-7540] Coercion from Interger literal to BigDecimal bind varia…
cb046fb 
…ble (apache#32) (apache#5622)

- Bump mvel to 2.5.1.Final
- Test cases
tkobayas added a commit to tkobayas/drools that referenced this pull request Feb 9, 2024
@tkobayas
[DROOLS-7292] Implement eval (apache#32)
62fd8ac
mariofusco added a commit that referenced this pull request Feb 14, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
3699d67 
#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (#10)

* Enhance test/grammar coverage. keyword collision (#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (#13)

* OpenRewrite applied for junit5 and assertj (#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (#15)

* [DROOLS-7286] Failed to parse binding with || (#21)

* [DROOLS-7287] Failed to parse comments in RHS (#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (#28)

* [DROOLS-7296] Implement from entry-point (#30)

* [DROOLS-7297] Implement import accumulate (#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (#31)

* [DROOLS-7292] Implement eval (#32)

* [DROOLS-7293] Implement extends (#33)

* [DROOLS-7294] Implement forall (#34)

* [DROOLS-7298] Implement memberOf (#35)

* [DROOLS-7300] Implement positional constraint (#36)

* [DROOLS-7304] Implement temporal operators (#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (#39)

* [DROOLS-7305] Implement type declaration (#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (#47)

* Add DescrDumperTest and fix the expression parser grammar (#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
mariofusco pushed a commit that referenced this pull request Feb 14, 2024
@tkobayas @mariofusco
[DROOLS-7292] Implement eval (#32)
f71a466
tkobayas added a commit to tkobayas/drools that referenced this pull request Feb 15, 2024
@tkobayas
[DROOLS-7292] Implement eval (apache#32)
7ea0832
rgdoliveira added a commit to rgdoliveira/drools that referenced this pull request Mar 27, 2024
@rgdoliveira
productized/modules: remove jpmml-migration-recipe as this module was…
7faf21b 
… dropped from upstream (apache#32)

jpmml-migration-recipe module was dropped as part of kie-issues-957
tkobayas added a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
9f48f0f 
apache#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (apache#10)

* Enhance test/grammar coverage. keyword collision (apache#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (apache#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (apache#13)

* OpenRewrite applied for junit5 and assertj (apache#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (apache#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (apache#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (apache#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (apache#15)

* [DROOLS-7286] Failed to parse binding with || (apache#21)

* [DROOLS-7287] Failed to parse comments in RHS (apache#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (apache#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (apache#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (apache#28)

* [DROOLS-7296] Implement from entry-point (apache#30)

* [DROOLS-7297] Implement import accumulate (apache#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (apache#31)

* [DROOLS-7292] Implement eval (apache#32)

* [DROOLS-7293] Implement extends (apache#33)

* [DROOLS-7294] Implement forall (apache#34)

* [DROOLS-7298] Implement memberOf (apache#35)

* [DROOLS-7300] Implement positional constraint (apache#36)

* [DROOLS-7304] Implement temporal operators (apache#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (apache#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (apache#39)

* [DROOLS-7305] Implement type declaration (apache#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (apache#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (apache#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (apache#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (apache#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (apache#47)

* Add DescrDumperTest and fix the expression parser grammar (apache#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
tkobayas added a commit to tkobayas/drools that referenced this pull request Jun 11, 2024
@tkobayas
[DROOLS-7292] Implement eval (apache#32)
47c7fe0
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 2, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
de27aac 
apache#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (apache#10)

* Enhance test/grammar coverage. keyword collision (apache#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (apache#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (apache#13)

* OpenRewrite applied for junit5 and assertj (apache#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (apache#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (apache#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (apache#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (apache#15)

* [DROOLS-7286] Failed to parse binding with || (apache#21)

* [DROOLS-7287] Failed to parse comments in RHS (apache#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (apache#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (apache#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (apache#28)

* [DROOLS-7296] Implement from entry-point (apache#30)

* [DROOLS-7297] Implement import accumulate (apache#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (apache#31)

* [DROOLS-7292] Implement eval (apache#32)

* [DROOLS-7293] Implement extends (apache#33)

* [DROOLS-7294] Implement forall (apache#34)

* [DROOLS-7298] Implement memberOf (apache#35)

* [DROOLS-7300] Implement positional constraint (apache#36)

* [DROOLS-7304] Implement temporal operators (apache#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (apache#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (apache#39)

* [DROOLS-7305] Implement type declaration (apache#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (apache#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (apache#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (apache#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (apache#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (apache#47)

* Add DescrDumperTest and fix the expression parser grammar (apache#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 2, 2024
@tkobayas
[DROOLS-7292] Implement eval (apache#32)
c7d1d33
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 11, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
46373ed 
apache#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (apache#10)

* Enhance test/grammar coverage. keyword collision (apache#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (apache#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (apache#13)

* OpenRewrite applied for junit5 and assertj (apache#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (apache#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (apache#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (apache#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (apache#15)

* [DROOLS-7286] Failed to parse binding with || (apache#21)

* [DROOLS-7287] Failed to parse comments in RHS (apache#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (apache#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (apache#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (apache#28)

* [DROOLS-7296] Implement from entry-point (apache#30)

* [DROOLS-7297] Implement import accumulate (apache#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (apache#31)

* [DROOLS-7292] Implement eval (apache#32)

* [DROOLS-7293] Implement extends (apache#33)

* [DROOLS-7294] Implement forall (apache#34)

* [DROOLS-7298] Implement memberOf (apache#35)

* [DROOLS-7300] Implement positional constraint (apache#36)

* [DROOLS-7304] Implement temporal operators (apache#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (apache#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (apache#39)

* [DROOLS-7305] Implement type declaration (apache#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (apache#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (apache#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (apache#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (apache#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (apache#47)

* Add DescrDumperTest and fix the expression parser grammar (apache#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
tkobayas added a commit to tkobayas/drools that referenced this pull request Oct 11, 2024
@tkobayas
[DROOLS-7292] Implement eval (apache#32)
ae2f781
tkobayas added a commit that referenced this pull request Oct 11, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
9da9b0e 
#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (#6)

* Enhance test/grammar coverage. and, or, listExpression (#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (#10)

* Enhance test/grammar coverage. keyword collision (#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (#13)

* OpenRewrite applied for junit5 and assertj (#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (#15)

* [DROOLS-7286] Failed to parse binding with || (#21)

* [DROOLS-7287] Failed to parse comments in RHS (#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (#28)

* [DROOLS-7296] Implement from entry-point (#30)

* [DROOLS-7297] Implement import accumulate (#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (#31)

* [DROOLS-7292] Implement eval (#32)

* [DROOLS-7293] Implement extends (#33)

* [DROOLS-7294] Implement forall (#34)

* [DROOLS-7298] Implement memberOf (#35)

* [DROOLS-7300] Implement positional constraint (#36)

* [DROOLS-7304] Implement temporal operators (#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (#39)

* [DROOLS-7305] Implement type declaration (#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (#47)

* Add DescrDumperTest and fix the expression parser grammar (#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
tkobayas added a commit that referenced this pull request Oct 11, 2024
@tkobayas
[DROOLS-7292] Implement eval (#32)
433809f
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
@tkobayas @mariofusco
@gitgabrio @lbenc135 @yurloc @rgdoliveira
[DROOLS-7591] Experiment branch : migrate a new drools-lsp parser int… (
d577bd6 
apache#5682)

* add antlr4 based drl parser

* bump to drools 8.16.0.Beta

* improve node position discovery

* first c3 integration

* Module reorganization (apache#2)

* WIP

* Ignore directories

* Add debug. Minor modifications

* WIP

* Fix tests - add comments

* manage null ast nodes and fix failing test

* improve drl parser

* Fix basic completion (apache#4)

* Add Java grammar, fix DRL grammar, simplify token index calculation, remove template code

* Add ignored tokens to completion

Co-authored-by: livio <livio.bencik@mindsmiths.com>

* add constraints parsing

* - Added DRLParserWrapper to store errors using DRLErrorListener (apache#5)

- Added MiscDRLParserTest which is being ported from RuleParserTest to enhance coverage.

* Enhance test/grammar coverage. function import, global, exists, not (apache#6)

* Enhance test/grammar coverage. and, or, listExpression (apache#7)

* Enhance test/grammar coverage. matches, single quoted string, escape (apache#9)

- Introduced drlExpression, drlPrimary, drlLiteral, DRL_STRING_LITERAL

* Enhance test/grammar coverage. dialect, invalid lhs (apache#10)

* Enhance test/grammar coverage. keyword collision (apache#11)

- Add "DRL_" prefix for DRL keywords for clarification

* Enhance test/grammar coverage. function, attributes, consequence (apache#12)

* Enhance test/grammar coverage. function, attributes, consequence
- better getText preserving whitespaces
- resolving WARNs because of overlapping keywords

* - No need to declare duplicate keywords

* Enhance test/grammar coverage. OR, inline map (apache#13)

* OpenRewrite applied for junit5 and assertj (apache#14)

* Enhance test/grammar coverage. label, consequenceLocation, test refac… (apache#15)

* Enhance test/grammar coverage. label, consequenceLocation, test refactoring, assertj best practice

* - better test method names

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design (apache#16)

* [DROOLS-7253] Review and improve drools-lsp parser Visitor design
- Remove currentConstructStack. Utilize return object instead.

* - Remove instance fields. Utilize return objects instead.

* [DROOLS-7270] Enhance test/grammar coverage : andRestriction, orRestriction (apache#4)

- Removed some unused cast

* [DROOLS-7271] Fully port RuleParserTest as MiscDRLParserTest with @disabled and priority comment (apache#10)

* [DROOLS-7285] Failed to parse and/or with parentheses in LHS (apache#15)

* [DROOLS-7286] Failed to parse binding with || (apache#21)

* [DROOLS-7287] Failed to parse comments in RHS (apache#23)

* [DROOLS-7287] Failed to parse comments in RHS

* - add rhs string check

* [DROOLS-7515] Parser : Accept plain text in RHS (apache#26)

* [DROOLS-7515] Parser : Accept plain text in RHS

* - Handle keyword token in RHS

* - Removed sysout

* - Revert statementKeywords. Instead, define DRL_END with newline or EOF

* - fix method name

* [DROOLS-7288] Failed to parse complex parentheses (apache#27)

* [DROOLS-7288] Failed to parse complex parentheses
- bump to 8.43.0.Final

* additional tests

* [DROOLS-7289] Implement accumulate (apache#28)

* [DROOLS-7296] Implement from entry-point (apache#30)

* [DROOLS-7297] Implement import accumulate (apache#29)

* [DROOLS-7290] Implement BigInteger literal, BigDecimal literal (apache#31)

* [DROOLS-7292] Implement eval (apache#32)

* [DROOLS-7293] Implement extends (apache#33)

* [DROOLS-7294] Implement forall (apache#34)

* [DROOLS-7298] Implement memberOf (apache#35)

* [DROOLS-7300] Implement positional constraint (apache#36)

* [DROOLS-7304] Implement temporal operators (apache#38)

- Also covers [DROOLS-7303] Implement sliding window

* [DROOLS-7301] Implement query (apache#37)

- Also partially fixes [DROOLS-7302] Implement semicolon delimiter

* [DROOLS-7295] Implement from collect (apache#39)

* [DROOLS-7305] Implement type declaration (apache#40)

- also covers [DROOLS-7291] Implement entry-point declaration
- also covers window declaration

* [DROOLS-7306] Implement unification (apache#41)

* [DROOLS-7306] Implement unification
- Also [DROOLS-7307] Parse attribute agenda-group

* [DROOLS-7308] Parse attribute without value
- Also [DROOLS-7309] Parse attribute with parentheses

* [DROOLS-7310] parse nested parentheses (apache#42)

* [DROOLS-7310] parse nested parentheses

* - Adding code commentes and explanations
- Adding more nested level tests

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-p… (apache#43)

* [DROOLS-7577] drools-lsp : Add comments and explanations for drools-parser

* removed syntax examples

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools (apache#44)

- Add some methods to call from drools code base

* Move necessary files without any additional modifications

* Update DRL6Expressions.g4 to ANTLR 4 (apache#47)

* Add DescrDumperTest and fix the expression parser grammar (apache#48)

* Add DescrDumperTest

* Fix it

* [DROOLS-7591] Experiment branch : migrate a new drools-lsp parser into drools
- New parser is migrated in drools-drl/drools-drl-parser with org.drools.drl10.parser package
- To enable the new parser, run `mvn test -PDRL10`
- At the moment, we get lots of test failures especially in drools-model/drools-model-codegen and drools-test-coverage/test-compiler-integration

* - License header
- Revert an inappropriate test edit
- Removed unnecessary profile
- Clarify unsupported methods
- Removed unnecessary bom dependency

---------

Co-authored-by: mariofusco <mario.fusco@gmail.com>
Co-authored-by: Gabriele Cardosi <gabriele.cardosi@gmail.com>
Co-authored-by: Livio Benčik <lbenc135@gmail.com>
Co-authored-by: livio <livio.bencik@mindsmiths.com>
Co-authored-by: Jiří Locker <jiri.locker@gmail.com>
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Oct 24, 2024
@tkobayas @rgdoliveira
[DROOLS-7292] Implement eval (apache#32)
1521e05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@zenix @triceo @etirelli