[DROOLS-7214] non-executable-model doesn't react to bind-only Map pro… #4771
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…perty with map access operator - Test case only
…perty with map access operator - Fix
mariofusco
approved these changes
Oct 27, 2022
pibizza
requested changes
Oct 27, 2022
| while (cursor < expression.length()) { | ||
| char c = expression.charAt(cursor); | ||
| if (!Character.isWhitespace(c)) { | ||
| return "" + c; |
There was a problem hiding this comment.
Since we are returning a one character string and using it to perform a comparison with a single char I suggest using a Char instead. As an alternative use String.valueOf(c) to create the string.
| @@ -1636,4 +1636,96 @@ private void testVariousCasePropFact(String modifyStatement, String... expectedR | |||
|
|
|||
| assertThat(results).containsExactly(expectedResults); | |||
| } | |||
|
|
|||
| @Test | |||
| public void testBindOnlyProp() { | |||
There was a problem hiding this comment.
I suggest expanding the Prop into Property - people should just read the name of the test aloud and understand what is supposed to test. Also sooner or later we have to stop using the test prefix for test methods. It is redundant. So this test would be bindOnlyPropertyReacts.
| } | ||
|
|
||
| @Test | ||
| public void testBindOnlyPropMap() { |
There was a problem hiding this comment.
AS above I suggest bindOnlyMapPropertyReacts
| } | ||
|
|
||
| @Test | ||
| public void testBindOnlyPropMapAccessOperator() { |
There was a problem hiding this comment.
AS above I suggest bindOnlyMapPropertyWithAccessOperatorReacts
| } | ||
|
|
||
| @Test | ||
| public void testBindOnlyPropListAccessOperator() { |
There was a problem hiding this comment.
AS above I suggest bindOnlyListPropertyWithAccessOperatorReacts
- lookAheadIgnoringSpaces to return a Character
|
@pibizza Thank you for the valuable inputs! All applied :) |
pibizza
approved these changes
Oct 28, 2022
|
Jenkins run cdb |
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Nov 1, 2022
apache#4771) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
mariofusco
pushed a commit
that referenced
this pull request
Nov 1, 2022
#4771) (#4784) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Nov 18, 2022
apache#4771) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Nov 18, 2022
apache#4771) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
mariofusco
pushed a commit
that referenced
this pull request
Nov 21, 2022
#4771) (#4824) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
mariofusco
pushed a commit
that referenced
this pull request
Nov 21, 2022
#4771) (#4823) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 30, 2023
apache#4771) (apache#4823) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 31, 2023
…le execution in multi threads (apache#13) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map pro… (apache#4771) (apache#4823) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character * Additional secondary super cache issue - Bump Version - Added benchmark to drools - Fixed secondary super cache on AgendaItem - Fix ObjectSinkNode, LeftTupleSinkNode - Fix ClassAwareObjectStore - Fix TerminalNode - Revert "Added benchmark to drools" - Revert "Bump Version"
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Oct 31, 2023
…le execution in multi threads (apache#14) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map pro… (apache#4771) (apache#4823) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character * Additional secondary super cache issue - Bump Version - Added benchmark to drools - Fixed secondary super cache on AgendaItem - Fix ObjectSinkNode, LeftTupleSinkNode - Fix ClassAwareObjectStore - Fix TerminalNode - Revert "Added benchmark to drools" - Revert "Bump Version"
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Nov 1, 2023
…le execution in multi threads (apache#14) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map pro… (apache#4771) (apache#4823) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character * Additional secondary super cache issue - Bump Version - Added benchmark to drools - Fixed secondary super cache on AgendaItem - Fix ObjectSinkNode, LeftTupleSinkNode - Fix ClassAwareObjectStore - Fix TerminalNode - Revert "Added benchmark to drools" - Revert "Bump Version"
tkobayas
added a commit
to tkobayas/drools
that referenced
this pull request
Nov 2, 2023
…le execution in multi threads (apache#14) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map pro… (apache#4771) (apache#4823) * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Test case only * [DROOLS-7214] non-executable-model doesn't react to bind-only Map property with map access operator - Fix * - test method name change - lookAheadIgnoringSpaces to return a Character * Additional secondary super cache issue - Bump Version - Added benchmark to drools - Fixed secondary super cache on AgendaItem - Fix ObjectSinkNode, LeftTupleSinkNode - Fix ClassAwareObjectStore - Fix TerminalNode - Revert "Added benchmark to drools" - Revert "Bump Version"
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…perty with map access operator
Ports
This PR is for 7.x
for 7.67.x -> https://github.com/kiegroup/drools/pull/4823
for 7.67.x-blue -> https://github.com/kiegroup/drools/pull/4824
for main -> https://github.com/kiegroup/drools/pull/4784
JIRA:
https://issues.redhat.com/browse/DROOLS-7214
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
a full production downstream build please add comment: Jenkins execute product fdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for mandrel checks
Run native checks against Mandrel image
Please add comment: Jenkins run mandrel
for a specific mandrel check
Run native checks against Mandrel image
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] mandrel
for mandrel lts checks
Run native checks against Mandrel image and quarkus lts branch
Please add comment: Jenkins run mandrel-lts
for a specific mandrel lts check
Run native checks against Mandrel image and quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] mandrel-lts