DROOLS-7552: improve updateObjectTypesList() #5552
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
reviewed
Oct 12, 2023
| // if count==0 then remove entry | ||
| if (uniqueObjectTypesInStore.get(object.getClass().getName()) == 0) { | ||
| uniqueObjectTypesInStore.remove(object.getClass().getName()); | ||
| if (inverseStorage.keySet().stream().filter(sObject -> sObject.getClass().equals(object.getClass())).findAny()!=null){ |
There was a problem hiding this comment.
findAny() returns Optional.empty() when there is no match, so comparing with null is not right, I think. Please check the execution path when the object class doesn't exist in inverseStorage.
There was a problem hiding this comment.
@tkobayas your comment is correct, comparing with null is not right, it always returns true. So, I will replace line 125 with
if (!inverseStorage.keySet().stream().filter(sObject -> sObject.getClass().equals(object.getClass())).findAny().isEmpty())
mariofusco
approved these changes
Oct 12, 2023
rgdoliveira
pushed a commit
to kiegroup/drools
that referenced
this pull request
Dec 13, 2023
* updateObjectTypesList() improvements * use isEmpty with findAny
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DROOLS-7552
This improvement is related to benchmark FireAndAlarmBenchmark findings (DROOLS-7545).