Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#647: add writeJunitReport to invoker configuration #5561

Merged
merged 1 commit into from
Oct 24, 2023

Conversation

jstastny-cz
Copy link
Contributor

@jstastny-cz jstastny-cz commented Oct 24, 2023

apache/incubator-kie-issues#647

Given that CI builds set maven.test.failure.ignore to true, any build failure would be silently ignored, unless invoker plugin writes the build fail as a junit report with failure outcome.

This is achieved by property writeJunitReport which is false by default and needs to be overriden.

To be validated by the test results of the PR check - they should contain test cases named as the invoked projects (I need guidance of the repository SMEs on which those should be).
EDIT: should be prefixed by maven.invoker.it AFAIK.

Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! thank you @jstastny-cz

@porcelli porcelli merged commit 5f7d2f9 into apache:main Oct 24, 2023
6 of 8 checks passed
@jstastny-cz jstastny-cz deleted the kie-issues#647 branch October 24, 2023 12:29
rgdoliveira pushed a commit to kiegroup/drools that referenced this pull request Dec 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants