Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

MakeConcrete always create an identityMap regardless of the equality behaviour #5605

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
+4 −4
Open

MakeConcrete always create an identityMap regardless of the equality behaviour #5605

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 4 additions & 4 deletions drools-core/src/main/java/org/drools/core/common/ClassAwareObjectStore.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -265,7 +265,7 @@ private ConcreteClassStore getOrCreateConcreteClassStore(Class<?> clazz) {
}

private ConcreteClassStore makeStoreConcrete(SingleClassStore storeToMakeConcrete) {
ConcreteClassStore store = storeToMakeConcrete.makeConcrete();
ConcreteClassStore store = storeToMakeConcrete.makeConcrete(this.isEqualityBehaviour);
Class<?> storedClass = storeToMakeConcrete.getStoredClass();

for (SingleClassStore classStore : storesMap.values()) {
Expand Down Expand Up @@ -296,7 +296,7 @@ public interface SingleClassStore extends Externalizable, FactHandleClassStore {
Iterator<InternalFactHandle> factHandlesIterator(boolean assrt);

boolean isConcrete();
ConcreteClassStore makeConcrete();
ConcreteClassStore makeConcrete(boolean isEqualityBehaviour);

default Iterator<InternalFactHandle> iterator() {
return factHandlesIterator(true);
Expand Down Expand Up @@ -428,8 +428,8 @@ public boolean isConcrete() {
}

@Override
public ConcreteClassStore makeConcrete() {
identityMap = new FactHandleMap(true);
public ConcreteClassStore makeConcrete(boolean isEqualityBehaviour) {
identityMap = new FactHandleMap(!isEqualityBehaviour);
return this;
}
}
Expand Down
Loading