[KIE-775] drools executable-model fails with a bind variable to a cal… #5636

tkobayas · 2023-12-20T09:30:34Z

…culation result of int and BigDecimal

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:

for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
- for jenkins job: please add comment: Jenkins run fdb
- for github actions job: add the label run_fdb
a compile downstream build please add comment: Jenkins run cdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

…culation result of int and BigDecimal

tkobayas · 2023-12-20T09:41:42Z

...n/src/main/java/org/drools/model/codegen/execmodel/generator/drlxparse/ConstraintParser.java

        } else if (drlx.getExpr() instanceof BinaryExpr) {
-            decl.setBoundVariable(PrintUtil.printNode(drlx.getExpr().asBinaryExpr().getLeft()));
+            Expression leftMostExpression = getLeftMostExpression(drlx.getExpr().asBinaryExpr());
+            decl.setBoundVariable(PrintUtil.printNode(leftMostExpression));
+            if (singleResult.getExpr() instanceof MethodCallExpr) {
+                // BinaryExpr was converted to MethodCallExpr. Create a TypedExpression for the leftmost expression of the BinaryExpr
+                ExpressionTyperContext expressionTyperContext = new ExpressionTyperContext();
+                ExpressionTyper expressionTyper = new ExpressionTyper(context, singleResult.getPatternType(), bindId, false, expressionTyperContext);
+                TypedExpressionResult leftTypedExpressionResult = expressionTyper.toTypedExpression(leftMostExpression);
+                Optional<TypedExpression> optLeft = leftTypedExpressionResult.getTypedExpression();
+                if (!optLeft.isPresent()) {
+                    throw new IllegalStateException("Cannot create TypedExpression for " + drlx.getExpr().asBinaryExpr().getLeft());
+                }
+                singleResult.setBoundExpr(optLeft.get());
+            }


~~Hmm, this part may be duplicated with AbstractExpressionBuilder.getBindingExpression()~~ ah, no, it's not duplicated. I think this is better because explicitly setting the boundExpr.

tkobayas · 2023-12-21T14:22:22Z

GHA kogito failures : Not related to this PR.

2023-12-21T09:29:04.6641757Z [ERROR] Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor (default-descriptor) on project kogito-maven-plugin: Execution default-descriptor of goal org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed: Unsupported class file major version 61 -> [Help 1]
2023-12-21T09:29:04.6647185Z org.apache.maven.lifecycle.LifecycleExecutionException: Failed to execute goal org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor (default-descriptor) on project kogito-maven-plugin: Execution default-descriptor of goal org.apache.maven.plugins:maven-plugin-plugin:3.6.0:descriptor failed: Unsupported class file major version 61

tkobayas · 2023-12-21T14:28:25Z

.../main/java/org/drools/model/codegen/execmodel/generator/expressiontyper/ExpressionTyper.java

+            if (shouldConvertArithmeticBinaryToMethodCall(operator, left.getType(), right.getType())) {
+                Expression expression = convertArithmeticBinaryToMethodCall(combo, of(typeCursor), ruleContext);
+                java.lang.reflect.Type binaryType = getBinaryTypeAfterConversion(left.getType(), right.getType());
+                return of(new TypedExpression(expression, binaryType));
+            } else {
+                return of(new TypedExpression(combo, left.getType()));
+            }


This PR basically does "convert BigDecimal arithmetic BinaryExpr to MathodCallExpr" in ExpressionTyper.

For handling BigInteger and adding BigInteger tests would be addressed by apache/incubator-kie-issues#753

tkobayas · 2023-12-22T01:49:36Z

@lucamolteni @mariofusco Please review this, but not rushing. After the holidays would be fine :)

tkobayas · 2024-01-09T08:23:37Z

@mariofusco Please merge, thanks!

…culation result of int and BigDecimal (apache#5636)

…culation result of int and BigDecimal (apache#5636) (#2)

…culation result of int and BigDecimal (apache#5636) (#2) (#5) Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>

…culation result of int and BigDecimal (apache#5636) (#2) (#4) Co-authored-by: Toshiya Kobayashi <toshiyakobayashi@gmail.com>

…culation result of int and BigDecimal (apache#5636)

…culation result of int and BigDecimal (apache#5636) (cherry picked from commit fe2dbac)

[KIE-775] drools executable-model fails with a bind variable to a cal…

5a8f65d

…culation result of int and BigDecimal

tkobayas commented Dec 20, 2023

View reviewed changes

tkobayas marked this pull request as draft December 20, 2023 10:05

tkobayas marked this pull request as ready for review December 21, 2023 09:16

tkobayas commented Dec 21, 2023

View reviewed changes

tkobayas requested review from lucamolteni and mariofusco December 21, 2023 14:29

mariofusco approved these changes Dec 22, 2023

View reviewed changes

lucamolteni approved these changes Jan 9, 2024

View reviewed changes

mariofusco merged commit fe2dbac into apache:main Jan 9, 2024
9 of 17 checks passed

tkobayas mentioned this pull request Jan 10, 2024

drools executable-model fails with a bind variable to a calculation result of int and BigDecimal apache/incubator-kie-issues#775

Closed

tkobayas added a commit to tkobayas/drools that referenced this pull request Jan 12, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal…

2501a0b

…culation result of int and BigDecimal (apache#5636)

tkobayas mentioned this pull request Jan 12, 2024

[RHDM-2020] [KIE-775] drools executable-model fails with a bind variable to a cal… kiegroup/drools#2

Merged

mariofusco pushed a commit to kiegroup/drools that referenced this pull request Jan 15, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal…

53b1cd4

…culation result of int and BigDecimal (apache#5636) (#2)

github-actions bot pushed a commit to kiegroup/drools that referenced this pull request Jan 16, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal…

4468db3

…culation result of int and BigDecimal (apache#5636) (#2)

github-actions bot pushed a commit to kiegroup/drools that referenced this pull request Jan 16, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal…

6fc614c

…culation result of int and BigDecimal (apache#5636) (#2)

This was referenced Jan 16, 2024

[7.67.x] [RHDM-2020] [KIE-775] drools executable-model fails with a bind variable to a cal… kiegroup/drools#4

Merged

[7.67.x-blue] [RHDM-2020] [KIE-775] drools executable-model fails with a bind variable to a cal… kiegroup/drools#5

Merged

rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Jan 16, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal…

00e99f1

…culation result of int and BigDecimal (apache#5636)

baldimir pushed a commit to baldimir/drools that referenced this pull request Feb 28, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal…

edd542d

…culation result of int and BigDecimal (apache#5636) (cherry picked from commit fe2dbac)

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

[KIE-775] drools executable-model fails with a bind variable to a cal… #5636

[KIE-775] drools executable-model fails with a bind variable to a cal… #5636

tkobayas commented Dec 20, 2023

tkobayas Dec 20, 2023 •

edited

Loading

tkobayas commented Dec 21, 2023

tkobayas Dec 21, 2023 •

edited

Loading

tkobayas commented Dec 22, 2023

tkobayas commented Jan 9, 2024

[KIE-775] drools executable-model fails with a bind variable to a cal… #5636

[KIE-775] drools executable-model fails with a bind variable to a cal… #5636

Conversation

tkobayas commented Dec 20, 2023

tkobayas Dec 20, 2023 • edited Loading

Choose a reason for hiding this comment

tkobayas commented Dec 21, 2023

tkobayas Dec 21, 2023 • edited Loading

Choose a reason for hiding this comment

tkobayas commented Dec 22, 2023

tkobayas commented Jan 9, 2024

tkobayas Dec 20, 2023 •

edited

Loading

tkobayas Dec 21, 2023 •

edited

Loading