[incubator-kie-issues#854] DMN - Add implicit type conversion of date to date and time when necessary #5664
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 4 commits
January 18, 2024 17:35
|
Reopen of #5657 |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5664 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5664/1/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.DMNRuntimeTest.testDateAndTime[false]expected:<...me"=2015-12-24T00:00[Z (java.time.Zoned]DateTime), "fromYear...> but was:<...me"=2015-12-24T00:00[ (java.time.Local]DateTime), "fromYear...>org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[KIE_API_TYPECHECK]expected:<...me.LocalDate), "from[]YearMonthDay"=1999-1...> but was:<...me.LocalDate), "from[StringToDateTime"=2015-12-24T00:00 (java.time.LocalDateTime), "from]YearMonthDay"=1999-1...>org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[BUILDER_DEFAULT_NOCL_TYPECHECK]expected:<...me.LocalDate), "from[]YearMonthDay"=1999-1...> but was:<...me.LocalDate), "from[StringToDateTime"=2015-12-24T00:00 (java.time.LocalDateTime), "from]YearMonthDay"=1999-1...> |
tarilabs
reviewed
Jan 25, 2024
There was a problem hiding this comment.
I believe I already commented per #5657 (comment) same comments apply here
gitgabrio
commented
Jan 25, 2024
| @@ -138,6 +142,17 @@ public CompiledExpression compileFeelExpression(DMNCompilerContext ctx, String e | |||
| feelctx.addInputVariableType( entry.getKey(), ((BaseDMNTypeImpl) entry.getValue()).getFeelType() ); | |||
| } | |||
| feelctx.setFEELTypeRegistry(model.getTypeRegistry()); | |||
| // TODO: EXPERIMENT | |||
| String baseExpression = expression.contains("(") ? expression.substring(0, expression.indexOf("(")) : expression; | |||
There was a problem hiding this comment.
in-memory date to date time expression-string conversion
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5664 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5664/2/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.DMNRuntimeTest.testDateAndTime[false]expected:<...me"=2015-12-24T00:00[Z (java.time.Zoned]DateTime), "fromYear...> but was:<...me"=2015-12-24T00:00[ (java.time.Local]DateTime), "fromYear...>org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[KIE_API_TYPECHECK]expected:<...me.LocalDate), "from[]YearMonthDay"=1999-1...> but was:<...me.LocalDate), "from[StringToDateTime"=2015-12-24T00:00 (java.time.LocalDateTime), "from]YearMonthDay"=1999-1...>org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[BUILDER_DEFAULT_NOCL_TYPECHECK]expected:<...me.LocalDate), "from[]YearMonthDay"=1999-1...> but was:<...me.LocalDate), "from[StringToDateTime"=2015-12-24T00:00 (java.time.LocalDateTime), "from]YearMonthDay"=1999-1...> |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5664 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5664/4/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.DMNRuntimeTest.testDateAndTime[false][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[KIE_API_TYPECHECK][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[BUILDER_DEFAULT_NOCL_TYPECHECK][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[BUILDER_DEFAULT_NOCL_TYPECHECK_TYPESAFE][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[KIE_API_TYPECHECK_TYPESAFE][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5664 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5664/5/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.DMNRuntimeTest.testDateAndTime[false][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[KIE_API_TYPECHECK][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[BUILDER_DEFAULT_NOCL_TYPECHECK][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[BUILDER_DEFAULT_NOCL_TYPECHECK_TYPESAFE][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> org.kie.dmn.core.DMNStronglyTypedSupportTest.testDateAndTime[KIE_API_TYPECHECK_TYPESAFE][Message [id=0, level=ERROR, path=0007-date-time.dmn, line=68, column=-1text=DMN: Error while evaluating node 'fromStringToDateTime': the declared result type is 'DMNType{ http://www.omg.org/spec/DMN/20180521/FEEL/ : date and time }' but the actual value '2015-12-24' is not an instance of that type (Error evaluating node) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=122, column=-1 text=DMN: Unable to evaluate decision 'Date-Time2' as it depends on decision 'Date' (DMN id: _7df22028-4b5b-4594-89c7-a80b8aec526f, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=266, column=-1 text=DMN: Unable to evaluate decision 'cHour' as it depends on decision 'Date-Time2' (DMN id: _087e3f57-8ea6-4857-a080-fadc5a1dd9e8, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=239, column=-1 text=DMN: Unable to evaluate decision 'cDay' as it depends on decision 'Date' (DMN id: _04c6bedc-bc63-464f-8e61-c039d24a47bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=188, column=-1 text=DMN: Unable to evaluate decision 'dtDuration2' as it depends on decision 'Date-Time2' (DMN id: _a2c48b03-6e72-4846-99cc-02f3747c6867, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=215, column=-1 text=DMN: Unable to evaluate decision 'sumDurations' as it depends on decision 'dtDuration2' (DMN id: _14f9f361-8c3c-455b-9c97-fe15201e3b5e, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=227, column=-1 text=DMN: Unable to evaluate decision 'ymDuration2' as it depends on decision 'Date-Time2' (DMN id: _cbac111e-ca71-4fac-a921-175ffd767055, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=302, column=-1 text=DMN: Unable to evaluate decision 'years' as it depends on decision 'ymDuration2' (DMN id: _91fb395d-8173-4ed3-95f7-f790bd3967ab, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=257, column=-1 text=DMN: Unable to evaluate decision 'cMonth' as it depends on decision 'Date' (DMN id: _2cf37ed0-590d-4f97-b58b-46eaa424b965, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=293, column=-1 text=DMN: Unable to evaluate decision 'cTimezone' as it depends on decision 'Date-Time2' (DMN id: _81f97dd0-29ea-4bab-9540-b70a2fdf8ff3, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=203, column=-1 text=DMN: Unable to evaluate decision 'hoursInDuration' as it depends on decision 'dtDuration2' (DMN id: _634e7bf4-782f-43f0-8b4f-cd8a3146da38, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=134, column=-1 text=DMN: Unable to evaluate decision 'Time2' as it depends on decision 'Date-Time2' (DMN id: _1f2b08ce-3c6b-4e22-a747-8d9f378e9035, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=284, column=-1 text=DMN: Unable to evaluate decision 'cSecond' as it depends on decision 'Date-Time2' (DMN id: _4af88a8f-92e4-4f2d-bde1-e8a36b27e5bf, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=275, column=-1 text=DMN: Unable to evaluate decision 'cMinute' as it depends on decision 'Date-Time2' (DMN id: _6836a944-7f7b-4c98-8a7a-a573494110fd, The referenced node was not found) ] Message [id=0, level=ERROR, path=0007-date-time.dmn, line=248, column=-1 text=DMN: Unable to evaluate decision 'cYear' as it depends on decision 'Date' (DMN id: _dc18ebe0-6762-4734-aeb3-ed4fb861865c, The referenced node was not found) ]] Expecting value to be false but was true expected:<[fals]e> but was:<[tru]e> |
|
@tarilabs @baldimir @yesamer from date to date and time: my understanding is that even in the following case the target is date and time, and actually returned object should be Of course, I may be wrong on different aspects, here, so any advice would be extemely appreciated. |
tarilabs
reviewed
Jan 26, 2024
There was a problem hiding this comment.
Thank you for the update. The way I understand this PR as it stands right now, make coercion only for results of entry in DMN boxed Context.
To me, #5657 (comment) always applies.
To me, you need B.1 on function invocation and B.2 on type check for coercion on return.
So, this PR in the way I understand does not cover for B.1, and for B.2 covers only in a specific case out of all the boxed expressions.
You might want to consider, as previously suggested, to break down task into subtasks, if that helps with complexity.
Hope this helps you and @baldimir make evaluations on the best way to proceed on this one!
|
Thanks @tarilabs, I'll create another different test to follow your
suggestion!
Il Ven 26 Gen 2024, 15:21 Matteo Mortari ***@***.***> ha
scritto:
… ***@***.**** commented on this pull request.
Thank you for the update. The way I understand this PR as it stands right
now, make coercion only for results of entry in DMN boxed Context.
To me, #5657 (comment)
<#5657 (comment)>
always applies.
To me, you need B.1 on function invocation and B.2 on type check for
coercion on return.
So, this PR in the way I understand does not cover for B.1, and for B.2
covers only in a specific case out of all the boxed expressions.
You might want to consider, as previously suggested, to break down task
into subtasks, if that helps with complexity.
Hope this helps you and @baldimir <https://github.com/baldimir> make
evaluations on the best way to proceed on this one!
—
Reply to this email directly, view it on GitHub
<#5664 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAF25CSNOGPFQOKDPSAZ6ITYQO3VFAVCNFSM6AAAAABCI6YRFGVHI2DSMVQWIX3LMV43YUDVNRWFEZLROVSXG5CSMV3GSZLXHMYTQNBVHA2DKOBXGE>
.
You are receiving this because you authored the thread.Message ID:
***@***.***>
|
|
HI @tarilabs WIth my current knowledge of DMN spec, I think this implement the use-case in point; but during the execution the code still does not hit the code you mentioned (for the
|
|
Can you folks (@gitgabrio @baldimir) kindly try first to elaborate further based on previous comments (if deemed helpful), and if questions are remaining based on that, to refer back to me for any new pending/remaining questions, please? I believe most of the questions were actually addressed with code pointers in the old #5657 (comment) not only in the semantic portion but also made reference to a possible way to address it with the internals linked (of course there might be several alternative ways too). I'm happy to be available for any (new) questions or doubts! |
|
Hi @tarilabs
because I could not find a way to verify/implement your suggestion; said differently, I understood the concept behind your suggestion (B.1) but I could not find a way to test it. The snippet I posted above is my last attempt but it does not work as expected - i.e. the code you pointed at is not hit when executing the and it fails at
because at this point the first parameter (LocalDate) is not the expected type (LocalDateTime). So, my very first step would be to have a proper dmn example/test to experiment with, since the ones I created so far seems not valid for that. |
added 3 commits
January 31, 2024 12:05
… Date is always to be treated as DateTime (not true). Removed redundant code on DMNType
|
@baldimir @yesamer
About 1)
About 2), it only resolve to my knowledge of the specs: if you have some suggestion, even related to previous discussions, feel free to share |
baldimir
approved these changes
Feb 7, 2024
yesamer
approved these changes
Feb 7, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Mar 11, 2024
… to date and time when necessary (apache#5664) * [private-bamoe-issues#244] DMN - Add implicit type conversion of date to date and time when necessary * [private-bamoe-issues#244] WIP * [private-bamoe-issues#244] WIP * [incubator-kie-issues#854] Experiment implicit date -> date-time conversion * [incubator-kie-issues#854] Remove implicit date -> date-time conversion * [incubator-kie-issues#854] Remove implicit date -> date-time conversion * [incubator-kie-issues#854] Converting value after its evaluation, when needed * [incubator-kie-issues#854] Minor modification on test * [incubator-kie-issues#854] WIP * [incubator-kie-issues#854] Centralize Coerce behaviour * [incubator-kie-issues#854] Add tests. Removed strong assumption where Date is always to be treated as DateTime (not true). Removed redundant code on DMNType * [incubator-kie-issues#854] Enforcing coercion inside lists * [incubator-kie-issues#854] Enforcing coercion inside collections --------- Co-authored-by: BAMOE CI <bamoe.ci@ibm.com> Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#854
Notes:
DMNContextEvaluatorLocalDateare transformed, and generated object is aZonedDateTimeDMNContextEvaluatorhas been done to improve test coverageHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.