[incubator-kie-issues#852] DMN - Allow importing into the default namespace #5684
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5684 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5684/1/display/redirect Test results:
Those are the test failures: org.kie.dmn.core.DMNCompilerTest.testEmptyNamedModelImport[KIE_API_TYPECHECK][Message [id=1, kieBase=defaultKieBase, level=ERROR, path=Importing_EmptyNamed_Model.dmn, line=60, column=-1text=DMN: Error compiling FEEL expression 'Say Hello( A Person )' for name 'Imported Greeting' on node 'Imported Greeting': syntax error near 'Hello' (DMN id: _d7e6836b-8491-487a-a653-5735daa85be2, Error compiling the referenced FEEL expression) ]] org.kie.dmn.core.DMNCompilerTest.testEmptyNamedModelImport[BUILDER_STRICT]Cannot invoke "org.kie.dmn.api.core.DMNDecisionResult.getResult()" because the return value of "org.kie.dmn.api.core.DMNResult.getDecisionResultByName(String)" is nullorg.kie.dmn.core.DMNCompilerTest.testEmptyNamedModelImport[BUILDER_DEFAULT_NOCL_TYPECHECK]Cannot invoke "org.kie.dmn.api.core.DMNDecisionResult.getResult()" because the return value of "org.kie.dmn.api.core.DMNResult.getDecisionResultByName(String)" is nullorg.kie.dmn.core.DMNCompilerTest.testEmptyNamedModelImport[BUILDER_DEFAULT_NOCL_TYPECHECK_TYPESAFE]Cannot invoke "org.kie.dmn.api.core.DMNDecisionResult.getResult()" because the return value of "org.kie.dmn.api.core.DMNResult.getDecisionResultByName(String)" is nullorg.kie.dmn.core.DMNCompilerTest.testEmptyNamedModelImport[KIE_API_TYPECHECK_TYPESAFE][Message [id=1, kieBase=defaultKieBase, level=ERROR, path=Importing_EmptyNamed_Model.dmn, line=60, column=-1text=DMN: Error compiling FEEL expression 'Say Hello( A Person )' for name 'Imported Greeting' on node 'Imported Greeting': syntax error near 'Hello' (DMN id: _d7e6836b-8491-487a-a653-5735daa85be2, Error compiling the referenced FEEL expression) ]] org.kie.dmn.legacy.tests.validation.v1_1.ValidatorTypeRefTest.testTYPEREF_NO_FEEL_TYPE_DefinitionsInput[Message [id=0, level=ERROR, path=null, line=25, column=-1text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ] Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] Expected size: 1 but was: 2 in: [Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ], Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] org.kie.dmn.legacy.tests.validation.v1_1.ValidatorTypeRefTest.testTYPEREF_NO_FEEL_TYPE_ReaderInput[Message [id=0, level=ERROR, path=null, line=25, column=-1text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ] Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] Expected size: 1 but was: 2 in: [Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ], Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] org.kie.dmn.legacy.tests.validation.v1_1.ValidatorTypeRefTest.testTYPEREF_NO_FEEL_TYPE_FileInput[Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ] Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] Expected size: 1 but was: 2 in: [Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1 text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ], Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-drools/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-drools -u #5684 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/drools/job/main/job/pullrequest_jobs/job/drools-pr/job/PR-5684/2/display/redirect Test results:
Those are the test failures: org.kie.dmn.legacy.tests.validation.v1_1.ValidatorTypeRefTest.testTYPEREF_NO_FEEL_TYPE_DefinitionsInput[Message [id=0, level=ERROR, path=null, line=25, column=-1text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ] Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] Expected size: 1 but was: 2 in: [Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ], Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] org.kie.dmn.legacy.tests.validation.v1_1.ValidatorTypeRefTest.testTYPEREF_NO_FEEL_TYPE_ReaderInput[Message [id=0, level=ERROR, path=null, line=25, column=-1text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ] Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] Expected size: 1 but was: 2 in: [Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ], Message [id=0, level=ERROR, path=null, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] org.kie.dmn.legacy.tests.validation.v1_1.ValidatorTypeRefTest.testTYPEREF_NO_FEEL_TYPE_FileInput[Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ] Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] Expected size: 1 but was: 2 in: [Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1 text=DMN: Type reference 'ssstringgg' is not a valid FEEL type reference on node 'Full Name' (The listed type reference could not be resolved) ], Message [id=0, level=ERROR, path=/home/jenkins/workspace/llrequest_jobs_drools-pr_PR-5684/kogito-pipelines/bc/apache_incubator-kie-drools/kie-dmn/kie-dmn-legacy-tests/target/test-classes/org/kie/dmn/legacy/tests/validation/v1_1/typeref/TYPEREF_NO_FEEL_TYPE.dmn, line=25, column=-1 text=DMN: Unable to resolve type reference 'ssstringgg' on node 'Full Name' (The listed type definition was not found) ]] |
baldimir
approved these changes
Feb 12, 2024
yesamer
approved these changes
Feb 13, 2024
…ique name for imported model
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Mar 11, 2024
…espace (apache#5684) * [private-bamoe-issues#253] WIP - working only ItemDefNode import * [incubator-kie-issues#852] WIP * [incubator-kie-issues#852] WIP - experimenting different approach * [incubator-kie-issues#852] WIP - Experimenting model merge. * [incubator-kie-issues#852] WIP - Working Imported model test * [incubator-kie-issues#852] Working state * [incubator-kie-issues#852] Add tests. Minor fixes * [incubator-kie-issues#852] Fixing UnnamedImportUtilsTest - using a unique name for imported model --------- Co-authored-by: BAMOE CI <bamoe.ci@ibm.com> Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#852
How to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] tests
for a full downstream build
run_fdba compile downstream build please add comment: Jenkins run cdb
an upstream build please add comment: Jenkins run upstream
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [drools|kogito-runtimes|kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.