[kie-issues#986] Coerce object to String in executable model codegen #5761
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tkobayas
approved these changes
Mar 5, 2024
yesamer
approved these changes
Mar 5, 2024
gitgabrio
requested changes
Mar 5, 2024
.../main/java/org/drools/model/codegen/execmodel/generator/expressiontyper/ExpressionTyper.java
Outdated
Show resolved
Hide resolved
.../drools-model-codegen/src/test/java/org/drools/model/codegen/execmodel/TypeCoercionTest.java
Show resolved
Hide resolved
|
Based on feedback, I redid the changes a bit. There were concerns, that it is not clear what side effects the original ArithmeticCoercionExpression class has, when reading/debugging the code. So I reorganized it a bit. |
mariofusco
approved these changes
Mar 5, 2024
tkobayas
approved these changes
Mar 6, 2024
baldimir
added a commit
to baldimir/drools
that referenced
this pull request
Mar 6, 2024
…pache#5761) * [kie-issues#986] Coerce object to String in executable model code generation. * [kie-issues#986] Simplify check for need of coercion. * Extract the check for coercion. * Update names of the classes for number and string arithmetic coercion. (cherry picked from commit 30e2da3)
baldimir
added a commit
that referenced
this pull request
Mar 7, 2024
rgdoliveira
pushed a commit
to rgdoliveira/drools
that referenced
this pull request
Mar 11, 2024
…pache#5761) * [kie-issues#986] Coerce object to String in executable model code generation. * [kie-issues#986] Simplify check for need of coercion. * Extract the check for coercion. * Update names of the classes for number and string arithmetic coercion.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes apache/incubator-kie-issues#986
For binary expression, only numeric arithmetic operations were considered during code generation.