Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#908] Validate new DMN 1.5 features #5785

Merged
merged 7 commits into from
Mar 15, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Mar 14, 2024

Fixes apache/incubator-kie-issues#908

Needed by
apache/incubator-kie-kogito-runtimes#3442
apache/incubator-kie-kogito-apps#2014
apache/incubator-kie-kogito-examples#1894

This PR

  1. move shared dmn models in the kie-dmn-test-resources
  2. modify DMNValidation to fix for new features
  3. test validation and execution of all the new features
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

Gabriele-Cardosi added 6 commits March 13, 2024 14:53
…esources. Adapted UnnamedImportUtilsTest.

Add kie-dmn-test-resources as dependency for kie-dmn-validation. Add fix for empty name import. Not working: references to unnamed imported model
… DateRangeLoop, listreplace, unnamed import
@gitgabrio gitgabrio merged commit 6281abd into apache:main Mar 15, 2024
9 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#908 branch March 15, 2024 13:02
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Mar 27, 2024
* [incubator-kie-issues#908] WIP. Moved shared models to kie-dmn-test-resources. Adapted UnnamedImportUtilsTest.
Add kie-dmn-test-resources as dependency for kie-dmn-validation. Add fix for empty name import. Not working: references to unnamed imported model

* [incubator-kie-issues#908] WIP. Working: references to unnamed imported model

* [incubator-kie-issues#908] WIP. Implemented validation/evaluation for DateRangeLoop, listreplace, unnamed import

* [incubator-kie-issues#908] Validate DMN 1.5 features. Moved shared models to kie-dmn-test-resources

* [incubator-kie-issues#908] Fixed model.

* [incubator-kie-issues#908] Add empty model name test

---------

Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Verify backend compliance with Frontend 1.5
3 participants