Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1044] DMN: Copy shared models from kogito-examples #5810

Merged
merged 6 commits into from
Apr 2, 2024

Conversation

gitgabrio
Copy link
Contributor

@gitgabrio gitgabrio commented Mar 28, 2024

Fixes apache/incubator-kie-issues#1044

Needed by:
apache/incubator-kie-kogito-runtimes#3458

This PR:

  1. move dmn models from kogito-examples to kie-dmn-testing-resources
  2. validate all valid_models from kie-dmn-validation module
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@gitgabrio
Copy link
Contributor Author

Windows failure unrelated

apache_incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/KieContainerTest.java:280 | test timed out after 20000 milliseconds
Not publishing test result due to skip_publishing=true
Error: There were 1 failed tests

@gitgabrio gitgabrio changed the title [incubator-kie-issues#1044] DMN: Move shared models from kogito-examples [incubator-kie-issues#1044] DMN: Copy shared models from kogito-examples Apr 2, 2024
@gitgabrio gitgabrio merged commit 95394f7 into apache:main Apr 2, 2024
9 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1044 branch April 2, 2024 13:18
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Apr 16, 2024
…les (apache#5810)

* [incubator-kie-issues#1044] WIP

* [incubator-kie-issues#1044] WIP

* [incubator-kie-issues#1044] WIP - all valid models validated

* [incubator-kie-issues#1044] Fix tags

* [incubator-kie-issues#1044] Validate all valid models from shared module

---------

Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

DMN: Copy shared models from kogito-examples
3 participants