Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1100] Fix oas-generation. Add tests #5858

Merged
merged 1 commit into from
Apr 22, 2024

Conversation

gitgabrio
Copy link
Contributor

Fixes apache/incubator-kie-issues#1100

This PR:

  1. fix wrong returns "allowedValues" instead of typeConstraints inside the enum
  2. fix wrongly returns empty enums when a TEST expression ("?") is defined as constraint
  3. fix unmanaged date ranges as constraints
  4. add checks on returned values consistency for enum population
  5. add unit tests
How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request and downstream checks

    • Push a new commit to the PR. An empty commit would be enough.
  • for a full downstream build

    • for github actions job: add the label run_fdb
  • for Jenkins PR check only

@gitgabrio gitgabrio requested review from baldimir and yesamer April 22, 2024 11:20
@gitgabrio
Copy link
Contributor Author

Drools windows failure unrelated
apache_incubator-kie-drools/drools-test-coverage/test-compiler-integration/src/test/java/org/drools/mvel/integrationtests/KieContainerTest.java:280 | test timed out after 20000 milliseconds

@yesamer yesamer merged commit 5c430aa into apache:main Apr 22, 2024
9 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1100 branch April 23, 2024 06:55
rgdoliveira pushed a commit to rgdoliveira/drools that referenced this pull request Apr 23, 2024
Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

FIX DMN schema generation
3 participants