BZ1301051: Column values are deleted after changing the operator in a Guided Decision Table #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… Guided Decision Table
| // These tests check legacy (pre-6.4.CR1) objects that have been de-serialized can be correctly read. | ||
| // DTCellValue52.valueString was set to an empty String statically and hence when the object was de-serialized | ||
| // it was possible for instances to have both a 'valueString (=="")' and '<another>Value' for types other than | ||
| // DataTypes.DataType.TYPE_STRING. For example. valueBoolean=true, valueString="", dataType=BOOLEAN. |
There was a problem hiding this comment.
Not sure if it matters, but I usually use the multiline comment for javadocs. This way the editor pick it up. You can read the comment when hovering the mouse over the class for example.
|
+1 |
Rikkola
pushed a commit
to Rikkola/drools
that referenced
this pull request
Jan 27, 2020
…able (apache#656) * GUVNOR-3486: [Guided Decision Table Graph] Refresh after removal of table * GUVNOR-3486: [Guided Decision Table Graph] Refresh after removal of table. Updates following peer review.
dupliaka
pushed a commit
to dupliaka/drools
that referenced
this pull request
Apr 1, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
See https://bugzilla.redhat.com/show_bug.cgi?id=1301051
This PR simply removes the values set for
valueStringanddataType. This is necessary as when aDTCellValue52is serialised from the server to the client the fields are set with reflection not the constructor and hence a NUMERICDTCellValue52would still have avalueString=="".