Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix @kogito-apps/form-details: The embedded monaco-editor doesn't show the proper syntax highlighting #527

Closed
pefernan opened this issue Aug 30, 2023 · 1 comment · Fixed by apache/incubator-kie-kogito-apps#1885
Assignees
Labels
area:form-generation-tool area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly

Comments

@pefernan
Copy link

pefernan commented Aug 30, 2023

Once you generate custom forms with the form-generation-tool they can be edited in the Runtime Tools Quarkus Extension allows editing them on the @kogito-apps/form-details component.

The component uses the monaco editor to allow the edition, but it it's missing the syntax highlighting.

This could be an issue on how the extension is bundled.

Steps to Reproduce:

  1. Generate any type of forms using form-generation-tool for any BPM Quarkus project in kogito-examples (for example process-usertasks-quarkus-with-console)
  2. In the project pom.xml add a dependency to the runtime-tools-quarkus-extension
  3. Start the Kogito project in dev mode (mvn clean quarkus:dev)
  4. Open the Dev ui (http://locahost:8080/q/dev) and click on the Forms link inside the Runtime Tools Quarkus Extension
  5. Once in the forms list, click in any form and you'll be brought to the form-details view, on the left side you'll se a monaco-editor. It will show up without any kind of syntax highlighting.
@jomarko jomarko added type:bug Something is behaving unexpectedly area:tools Issues affecting Apache KIE tooling projects area:bpmn Related to BPMN labels Aug 30, 2023
@yesamer yesamer added area:form-generation-tool and removed area:bpmn Related to BPMN labels Sep 1, 2023
@jomarko jomarko self-assigned this Sep 7, 2023
@jomarko
Copy link

jomarko commented Sep 13, 2023

image

There is a lot of errors regarding loading .woff2 assets. Error says for them 404 - not found on given url. One example of such url is:

  • http://localhost:9000/webapp/fonts/_/_/node_modules/.pnpm/@patternfly+react-core@4.276.8_react-dom@17.0.2_react@17.0.2/node_modules/@patternfly/react-core/dist/styles/assets/fonts/RedHatDisplay/RedHatDisplay-Bold.woff2

Then when I do grep for that file in kogito-apps/ui-packages I get multiple matches, but these two seems to be as most similar path:

  • ./dist/resources/webapp/_/_/node_modules/.pnpm/@patternfly+react-core@4.276.8_react-dom@17.0.2_react@17.0.2/node_modules/@patternfly/react-core/dist/styles/assets/fonts/RedHatDisplay/RedHatDisplay-Bold.woff2
  • ./dist/fonts/_/_/node_modules/.pnpm/@patternfly+react-core@4.276.8_react-dom@17.0.2_react@17.0.2/node_modules/@patternfly/react-core/dist/styles/assets/fonts/RedHatDisplay/RedHatDisplay-Bold.woff2

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area:form-generation-tool area:tools Issues affecting Apache KIE tooling projects type:bug Something is behaving unexpectedly
Projects
None yet
3 participants