kie-issues#527: Fix @kogito-apps/form-details: The embedded monaco-editor doesn't show the proper syntax highlighting #1885
Conversation
| { source: './dist/editor.worker.js', destination: './dist/webapp/' }, | ||
| { source: './dist/editor.worker.js.map', destination: './dist/webapp/' }, | ||
| { source: './dist/*.js', destination: './dist/resources/webapp/' }, | ||
| { source: './dist/*.map', destination: './dist/resources/webapp/' }, | ||
| { source: './dist/fonts', destination: './dist/resources/webapp/' }, | ||
| { source: './dist/fonts', destination: './dist/webapp/fonts' }, |
There was a problem hiding this comment.
Without this change, the ui-packages/runtime-tools-dev-ui-webapp showcase fails do load woff files - see the kie-issues#527.
After this change icons are loaded
|
@yesamer wait, because I think this is still on progress :P |
|
@yesamer yes, @pefernan is correct, this is still draft, work in progress, here is the current state () 1.) in About the second point, it is for sure related to copying assets to some path, we do not know proper path, from my work, I do not think all assets can be copied to the same path My plan is to: |
yesamer
changed the title
|
@yesamer @pefernan hi, let me share the status 1.) in About the second point, I tried to summarize our issue on quarkus zulip topic https://quarkusio.zulipchat.com/#narrow/stream/187030-users/topic/loading.20static.20resources The code we use in https://github.com/apache/incubator-kie-kogito-apps/blob/main/runtime-tools-quarkus-extension-parent/runtime-tools-quarkus-extension-deployment/src/main/java/org/kie/kogito/runtime/tools/quarkus/extension/deployment/DevConsoleProcessor.java#L58 is deprecated, if you check in IDE and seems quite different from documented What is your suggestion please? |
jomarko
force-pushed
the
kie-issues#527
branch
from
1b29c9b to
2a1266c
Compare
…itor doesn't show the proper syntax highlighting
jomarko
force-pushed
the
kie-issues#527
branch
from
2a1266c to
68a37f7
Compare
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/11/display/redirect Test results:
Those are the test failures: org.kie.kogito.jobs.service.resource.KeycloakJobServiceTest.(?)java.lang.reflect.InvocationTargetExceptionorg.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJobjava.lang.RuntimeException: Failed to start quarkusorg.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAlljava.lang.RuntimeException: Failed to start quarkusorg.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)java.lang.RuntimeException: Failed to start quarkusorg.kie.kogito.trusty.ui.KeycloakTrustyUIServiceIT.(?)java.lang.reflect.InvocationTargetExceptionorg.kie.kogito.trusty.ui.StaticContentTest.testIndexHtmljava.lang.reflect.InvocationTargetExceptionorg.kie.kogito.trusty.service.common.KeycloakTrustyServiceIT.(?)java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:247) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:372) at java.base/java.util.Optional.orElseGet(Optional.java:369) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:397) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:195) ... 11 more Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334) ... 16 more Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542) at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344) at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ... 17 more Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*' at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47) at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953) at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485) ... 19 more org.kie.kogito.trusty.service.common.api.DecisionsApiV1IT.testGetExecutionByIdjava.lang.reflect.InvocationTargetException |
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/12/display/redirect Test results:
Those are the test failures: org.kie.kogito.quarkus.outbox.OutboxIT.(?)org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8083, 39767] should be listening)PR check / Build projects / org.acme.travels.ApprovalsProcessIT.testApprovalProcessjava.lang.reflect.InvocationTargetExceptionorg.acme.travels.ApprovalsRestIT.testStartApprovalUnauthenticatedFailed to load ApplicationContextPR check / Build projects / org.acme.travels.ApprovalsRestIT.testStartApprovalAuthorizedFailed to load ApplicationContextorg.kie.kogito.springboot.outbox.OutboxIT.(?)org.testcontainers.containers.ContainerLaunchException: Timed out waiting for container port to open (172.17.0.1 ports: [8080, 39859] should be listening)org.acme.travels.ApprovalsProcessTestIT.testApprovalProcessFailed to load ApplicationContextorg.acme.travels.ApprovalsProcessTestIT.testApprovalProcessViaPhasesFailed to load ApplicationContextorg.acme.AcmeExchangeResourceIT.unauthorizedTestjava.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors[error]: Build step io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor#startKeycloakContainer threw an exception: java.lang.RuntimeException: org.testcontainers.containers.ContainerLaunchException: Container startup failed at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:247) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke0(Native Method) at java.base/jdk.internal.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:62) at java.base/jdk.internal.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43) at java.base/java.lang.reflect.Method.invoke(Method.java:566) at io.quarkus.deployment.ExtensionLoader$3.execute(ExtensionLoader.java:909) at io.quarkus.builder.BuildContext.run(BuildContext.java:281) at org.jboss.threads.ContextHandler$1.runWith(ContextHandler.java:18) at org.jboss.threads.EnhancedQueueExecutor$Task.run(EnhancedQueueExecutor.java:2449) at org.jboss.threads.EnhancedQueueExecutor$ThreadBody.run(EnhancedQueueExecutor.java:1478) at java.base/java.lang.Thread.run(Thread.java:829) at org.jboss.threads.JBossThread.run(JBossThread.java:501) Caused by: org.testcontainers.containers.ContainerLaunchException: Container startup failed at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:349) at org.testcontainers.containers.GenericContainer.start(GenericContainer.java:322) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.lambda$startContainer$4(KeycloakDevServicesProcessor.java:372) at java.base/java.util.Optional.orElseGet(Optional.java:369) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startContainer(KeycloakDevServicesProcessor.java:397) at io.quarkus.oidc.deployment.devservices.keycloak.KeycloakDevServicesProcessor.startKeycloakContainer(KeycloakDevServicesProcessor.java:195) ... 11 more Caused by: org.rnorth.ducttape.RetryCountExceededException: Retry limit hit with exception at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:88) at org.testcontainers.containers.GenericContainer.doStart(GenericContainer.java:334) ... 16 more Caused by: org.testcontainers.containers.ContainerLaunchException: Could not create/start container at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:542) at org.testcontainers.containers.GenericContainer.lambda$doStart$0(GenericContainer.java:344) at org.rnorth.ducttape.unreliables.Unreliables.retryUntilSuccess(Unreliables.java:81) ... 17 more Caused by: org.testcontainers.containers.ContainerLaunchException: Timed out waiting for log output matching '.*Keycloak.*started.*' at org.testcontainers.containers.wait.strategy.LogMessageWaitStrategy.waitUntilReady(LogMessageWaitStrategy.java:47) at org.testcontainers.containers.wait.strategy.AbstractWaitStrategy.waitUntilReady(AbstractWaitStrategy.java:52) at org.testcontainers.containers.GenericContainer.waitUntilContainerStarted(GenericContainer.java:953) at org.testcontainers.containers.GenericContainer.tryStart(GenericContainer.java:485) ... 19 more |
| @@ -5536,7 +5536,7 @@ packages: | |||
| engines: {node: '>= 10.14.2'} | |||
| dependencies: | |||
| '@jest/types': 26.6.2 | |||
| '@types/node': 20.4.1 | |||
| '@types/node': 18.16.19 | |||
There was a problem hiding this comment.
it's really curious how pnpm handles the versions. this kind ouf downgrades are surprising
|
PR job Reproducerbuild-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1885 --skipParallelCheckout NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1885/13/display/redirect Test results:
Those are the test failures: org.kie.kogito.index.ProcessDataIndexInfinispanIT.testProcessInstanceEvents1 expectation failed.JSON path errors doesn't match. Expected: null Actual: <[{message=Exception while fetching data (/UserTaskInstanceCommentUpdate) : Index 0 out of bounds for length 0, locations=[{line=1, column=12}], path=[UserTaskInstanceCommentUpdate], extensions={classification=DataFetchingException}}]> org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJobjava.lang.RuntimeException: Failed to start quarkusorg.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAlljava.lang.RuntimeException: Failed to start quarkusorg.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?)java.lang.RuntimeException: Failed to start quarkus |
|
@pefernan We can merge it after your approval, failing tests are unrelated. |
|
@yesamer already approved.. please go ahead! |
…itor doesn't show the proper syntax highlighting (apache#1885) * kie-issues#527: Fix @kogito-apps/form-details: The embedded monaco-editor doesn't show the proper syntax highlighting * fic react forms colors in runtime-tools-dev-ui-webapp * fix html colors in runtime-tools-dev-ui-webapp * Remove duplicates not needed in runtime-tools-dev-ui-webapp * trigger build
Partially closes apache/incubator-kie-issues#527
Because the mentioned ticket affects two modules:
This PR fix the
runtime-tools-dev-ui-webapp, howeverruntime-tools-quarkus-extension-deploymentstill needs to be addressed.Many thanks for submitting your Pull Request ❤️!
Please make sure that your PR meets the following requirements:
KOGITO-XYZ Subject[0.9.x] KOGITO-XYZ SubjectHow to replicate CI configuration locally?
Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.
build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.
How to retest this PR or trigger a specific build:
for pull request checks
Please add comment: Jenkins retest this
for a specific pull request check
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] tests
for quarkus branch checks
Run checks against Quarkus current used branch
Please add comment: Jenkins run quarkus-branch
for a quarkus branch specific check
Run checks against Quarkus current used branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-branch
for quarkus main checks
Run checks against Quarkus main branch
Please add comment: Jenkins run quarkus-main
for a specific quarkus main check
Run checks against Quarkus main branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-main
for quarkus lts checks
Run checks against Quarkus lts branch
Please add comment: Jenkins run quarkus-lts
for a specific quarkus lts check
Run checks against Quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] quarkus-lts
for native checks
Run native checks
Please add comment: Jenkins run native
for a specific native check
Run native checks
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native
for native lts checks
Run native checks against quarkus lts branch
Please add comment: Jenkins run native-lts
for a specific native lts check
Run native checks against quarkus lts branch
Please add comment: Jenkins (re)run [kogito-apps|kogito-examples] native-lts
How to backport a pull request to a different branch?
In order to automatically create a backporting pull request please add one or more labels having the following format
backport-<branch-name>, where<branch-name>is the name of the branch where the pull request must be backported to (e.g.,backport-7.67.xto backport the original PR to the7.67.xbranch).Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.
If something goes wrong, the author will be notified and at this point a manual backporting is needed.
Quarkus-3 PR check is failing ... what to do ?
The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.The first patch, called
0001_before_sh.patch, is generated from Openrewrite.ci/environments/quarkus-3/quarkus3.ymlrecipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.No panic, there is an easy way to regenerate it. You just need to comment on the PR:
and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.
Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.