Remove jsonpath@1.1.1 (CVE-2023-26115)

apache · Sep 14, 2023 · 5d73010 · 5d73010
1 parent cb9f921
commit 5d73010
Show file tree

Hide file tree

Showing 4 changed files with 9,447 additions and 3,249 deletions.
diff --git a/ui-packages/packages/components-common/package.json b/ui-packages/packages/components-common/package.json
@@ -34,7 +34,6 @@
     "@patternfly/react-table": "^4.113.0",
     "ajv": "^6.12.6",
     "apollo-boost": "^0.4.9",
-    "jsonpath": "^1.1.1",
     "lodash": "^4.17.21",
     "react": "^17.0.2",
     "react-dom": "^17.0.2",

diff --git a/ui-packages/packages/components-common/src/components/DataTable/DataTable.tsx b/ui-packages/packages/components-common/src/components/DataTable/DataTable.tsx
@@ -30,10 +30,10 @@ import isEmpty from 'lodash/isEmpty';
 import filter from 'lodash/filter';
 import sample from 'lodash/sample';
 import keys from 'lodash/keys';
+import get from 'lodash/get';
 import reduce from 'lodash/reduce';
 import isFunction from 'lodash/isFunction';
 import uuidv4 from 'uuid';
-import jp from 'jsonpath';
 import {
   OUIAProps,
   componentOuiaProps
@@ -64,7 +64,7 @@ interface IOwnProps {
 
 const getCellData = (dataObj: Record<string, unknown>, path: string) => {
   if (dataObj && path) {
-    return !isEmpty(jp.value(dataObj, path)) ? jp.value(dataObj, path) : 'N/A';
+    return get(dataObj, path) ?? 'N/A';
   } else {
     return 'N/A';
   }
@@ -94,7 +94,7 @@ const getColumns = (data: any[], columns: DataTableColumn[]) => {
           } as ICell;
         })
       : filter(keys(sample(data)), (key) => key !== '__typename').map(
-          (key) => ({ title: key, data: `$.${key}` } as ICell)
+          (key) => ({ title: key, data: key } as ICell)
         );
   } else if (columns) {
     return filter(columns, (column) => !isEmpty(column.path)).map((column) => {

diff --git a/ui-packages/packages/components-common/src/components/DataTable/tests/DataTable.test.tsx b/ui-packages/packages/components-common/src/components/DataTable/tests/DataTable.test.tsx
@@ -100,24 +100,24 @@ const stateColumnTransformer = (value) => {
 const columns: DataTableColumn[] = [
   {
     label: 'ProcessId',
-    path: '$.processId'
+    path: 'processId'
   },
   {
     label: 'Name',
-    path: '$.name',
+    path: 'name',
     isSortable: true
   },
   {
     label: 'Priority',
-    path: '$.priority'
+    path: 'priority'
   },
   {
     label: 'ProcessInstanceId',
-    path: '$.processInstanceId'
+    path: 'processInstanceId'
   },
   {
     label: 'State',
-    path: '$.state',
+    path: 'state',
     bodyCellTransformer: stateColumnTransformer,
     isSortable: true
   }