Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#626: disable Keycloak devservice #1895

Merged
merged 2 commits into from
Oct 16, 2023

Conversation

jstastny-cz
Copy link
Contributor

apache/incubator-kie-issues#626

Disabling Keycloak dev service that is started by default when quarkus-oidc maven dependency is used (https://quarkus.io/guides/dev-services#keycloak).

Given that our tests instead of the Dev service rely on org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource, the dev service started for no use and also caused failures due to strict startTimeout = 60s which was often exceeded. (even after apache/incubator-kie-issues#622 was fixed, because is a different thing)

Also there was version mismatch between the Keycloak image versions being used - that was the main reason to dig into this topic in first place.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 11, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1895 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1895/1/display/redirect

Test results:

  • PASSED: 2763
  • FAILED: 4

Those are the test failures:

PR check / Build projects / org.kie.kogito.it.jobs.CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details
org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus

@jstastny-cz
Copy link
Contributor Author

Jobs service test failures are known issues.

CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded is not clear, maybe random fail?

Validated the logs by downloading the consoleText output from https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/view/change-requests/job/PR-1895/1/consoleText
and executing following command with single value output:

[jstastny@IBM-PF3JSA31:/tmp]$ cat consoleText | sed -n 's#.*Container quay.io\/keycloak\/keycloak\(.*\)is starting.*#\1#p' | uniq
:20.0.2

Which means only the desired keycloak containers are started now.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Oct 11, 2023

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1895 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1895/2/display/redirect

Test results:

  • PASSED: 2776
  • FAILED: 3

Those are the test failures:

org.kie.kogito.jobs.service.messaging.InfinispanMessagingApiTest.cancelJob java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.repository.infinispan.InfinispanJobRepositoryTest.testFindAll java.lang.RuntimeException: Failed to start quarkus
org.kie.kogito.jobs.service.resource.KeycloakInfinispanJobServiceTest.(?) java.lang.RuntimeException: Failed to start quarkus

Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, the 3 remaining errors is due to infinispan library.proto not being registered. (which is not caused by this PR)

@wmedvede wmedvede self-requested a review October 13, 2023 07:38
@jstastny-cz
Copy link
Contributor Author

I am going ahead with the merge to stop wasting build resources by running unused services.

@jstastny-cz jstastny-cz merged commit 4855cec into apache:main Oct 16, 2023
@jstastny-cz jstastny-cz deleted the kie-issues#626 branch October 16, 2023 14:42
jstastny-cz added a commit to jstastny-cz/incubator-kie-kogito-apps that referenced this pull request Oct 24, 2023
* kie-issues#626: disable Keycloak devservice

* disable kafka in sync with other jobs service ITs

---------

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
jstastny-cz added a commit that referenced this pull request Oct 24, 2023
* kie-issues#626: disable Keycloak devservice (#1895)

* kie-issues#626: disable Keycloak devservice

* disable kafka in sync with other jobs service ITs

---------

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>

* add PR check triggering Jenkinsfile

---------

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
rgdoliveira pushed a commit to kiegroup/kogito-apps that referenced this pull request Dec 13, 2023
* kie-issues#626: disable Keycloak devservice

* disable kafka in sync with other jobs service ITs

---------

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants