-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#626: disable Keycloak devservice #1895
Conversation
Jobs service test failures are known issues. CallbackStateTimeoutsIT.callbackStateTimeoutsExceeded is not clear, maybe random fail? Validated the logs by downloading the consoleText output from https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/view/change-requests/job/PR-1895/1/consoleText
Which means only the desired keycloak containers are started now. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, the 3 remaining errors is due to infinispan library.proto not being registered. (which is not caused by this PR)
I am going ahead with the merge to stop wasting build resources by running unused services. |
* kie-issues#626: disable Keycloak devservice * disable kafka in sync with other jobs service ITs --------- Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
* kie-issues#626: disable Keycloak devservice (#1895) * kie-issues#626: disable Keycloak devservice * disable kafka in sync with other jobs service ITs --------- Co-authored-by: jstastny-cz <jan.stastny@ibm.com> * add PR check triggering Jenkinsfile --------- Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
* kie-issues#626: disable Keycloak devservice * disable kafka in sync with other jobs service ITs --------- Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
apache/incubator-kie-issues#626
Disabling Keycloak dev service that is started by default when quarkus-oidc maven dependency is used (https://quarkus.io/guides/dev-services#keycloak).
Given that our tests instead of the Dev service rely on
org.kie.kogito.testcontainers.quarkus.KeycloakQuarkusTestResource
, the dev service started for no use and also caused failures due to strict startTimeout = 60s which was often exceeded. (even after apache/incubator-kie-issues#622 was fixed, because is a different thing)Also there was version mismatch between the Keycloak image versions being used - that was the main reason to dig into this topic in first place.