Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

kie-issues#746: set timeout for testcontainers after waitingFor invocation #1932

Merged
merged 1 commit into from
Dec 7, 2023

Conversation

jstastny-cz
Copy link
Contributor

Fixes

Another batch of fixes due to misconfiguration of testcontainers coming from the fact that waitingFor method invocation drops previously configured withStartupTimeout value.
Need to override after each such call - can't rely on the value set in parent classes.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 6, 2023

PR job #3 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-apps -u #1932 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-apps-pr/job/PR-1932/3/display/redirect

Test results:

  • PASSED: 2836
  • FAILED: 1

Those are the test failures:

org.kie.kogito.index.service.MongoDomainIndexingServiceIT.testConcurrentProcessInstanceIndex Assertion condition defined as a org.kie.kogito.index.service.AbstractIndexingServiceIT 1 expectation failed.
JSON path data.ProcessInstances[0].state doesn't match.
Expected: is "COMPLETED"
Actual: ACTIVE
within 30 seconds.

@pefernan
Copy link
Contributor

pefernan commented Dec 7, 2023

@jstastny-cz should we have this in q3 branch?

@jstastny-cz
Copy link
Contributor Author

It would be safer - unless we are certain that the version of testcontainers used overthere has changed the implemented behavior.

@jstastny-cz
Copy link
Contributor Author

I'll try cherry-pick.

@jstastny-cz jstastny-cz merged commit 1a80a83 into apache:main Dec 7, 2023
5 checks passed
@jstastny-cz jstastny-cz deleted the kie-issues_746 branch December 7, 2023 10:28
rgdoliveira pushed a commit to kiegroup/kogito-apps that referenced this pull request Dec 13, 2023
…ation (apache#1932)

Co-authored-by: jstastny-cz <jan.stastny@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants