-
Notifications
You must be signed in to change notification settings - Fork 132
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[incubator-kie-issues-974] Document data index in compact architecture #2002
Conversation
|
||
The next dependency is added for quarkus and being able to use in-vm transport tier | ||
The next dependency is used to specify the storage of the data index and the transport tier at the same time. | ||
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
The two sentences starting with "The next dependency" could be a bit misleading. Maybe start the second one with "The same dependency" (and then remove "at the same time" at the end).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
* mongodb | ||
* postgresql | ||
|
||
Current system |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Maybe it would help to add a sentence to describe the diagram, eg:
## How data index works
![data-index](docs/data-index.png "Data Index")
The concepts to understand the above picture are:
* Transport: the medium used to transfer events between the runtime and the data index service. The transport is http in distributed environments, or in-vm for compact architecture.
* Storage: the persistence tier of the data index component.
* Data index: the main component responsible for creating/updating the data index, and for providing query capabilities.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
data-index/README.md
Outdated
|
||
|
||
|
||
of for quarkus |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
or
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
done
data-index/README.md
Outdated
|
||
|
||
More information about the Data Index images in here: | ||
[https://github.com/apache/incubator-kie-kogito-images?tab=readme-ov-file#kogito-data-index-component-images](https://github.com/apache/incubator-kie-kogito-images?tab=readme-ov-file#kogito-data-index-component-images images) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Remove ' images' to have the link rendered properly
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@elguardian thank you. Some minor suggestions, see my comments.
apache#2002) * [incubator-kie-issues-974] Document data index in compact architecture * fix
apache#2002) * [incubator-kie-issues-974] Document data index in compact architecture * fix
issue: apache/incubator-kie-issues#974