Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #3307 #3309

Merged
merged 2 commits into from
Dec 5, 2023
Merged

Fix #3307 #3309

merged 2 commits into from
Dec 5, 2023

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Dec 4, 2023 •
edited
Loading

Fixes #3307

@fjtirado fjtirado requested a review from krisv December 4, 2023 16:14
@fjtirado fjtirado force-pushed the Fix_#3307 branch 3 times, most recently from 0598f6d to 08e94dc Compare December 4, 2023 16:38
@fjtirado
Fix apache#3307 - Easier string interpolation
e8e43bf 
As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation
@fjtirado
Alternative implementation using optional
2b45e07
@fjtirado fjtirado merged commit a5c4af1 into apache:main Dec 5, 2023
6 checks passed
rgdoliveira pushed a commit to kiegroup/kogito-runtimes that referenced this pull request Dec 13, 2023
@fjtirado @rgdoliveira
Fix apache#3307 (apache#3309)
12309ac 
* Fix apache#3307 - Easier string interpolation

As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation

* Alternative implementation using optional
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this pull request Jan 10, 2024
@fjtirado
Fix apache#3307 (apache#3309)
52ab754 
* Fix apache#3307 - Easier string interpolation

As proposed in the issue description, remove the need for initial
quoutes in case of string interpolation

* Alternative implementation using optional
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wmedvede wmedvede wmedvede approved these changes

@ricardozanini ricardozanini ricardozanini approved these changes

@krisv krisv Awaiting requested review from krisv

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Make it easier to use JQ interpolation
3 participants
@fjtirado @ricardozanini @wmedvede