Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NO ISSUE] Update maven-plugin-plugin version to fix Java 17 compilation #3340

Merged
merged 2 commits into from
Dec 21, 2023

Conversation

baldimir
Copy link
Contributor

The version of maven-plugin-plugin was not compatible with Java 17. After the upgrade, the compilaton works.

@baldimir baldimir requested a review from mariofusco December 21, 2023 09:55
@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 21, 2023

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3340 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3340/1/display/redirect

Test results:

  • PASSED: 2428
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

@baldimir
Copy link
Contributor Author

I disabled another test - here is an issue for it apache/incubator-kie-issues#788

@baldimir baldimir requested a review from fjtirado December 21, 2023 11:14
@fjtirado
Copy link
Contributor

@baldimir What was not compiling with previous maven plugin version?

@pefernan
Copy link
Contributor

Not sure if I'd disable the test on this PR, but approving to fix the build

@baldimir
Copy link
Contributor Author

@fjtirado the build of kogito-maven-plugin failed on unsupported class format.

@fjtirado
Copy link
Contributor

@baldimir Lets disable the test with a different PR

@baldimir baldimir merged commit 1c56039 into apache:main Dec 21, 2023
1 of 6 checks passed
@kie-ci3
Copy link
Contributor

kie-ci3 commented Dec 21, 2023

PR job #2 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3340 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3340/2/display/redirect

Test results:

  • PASSED: 3330
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.ExpressionRestFromImageIT.testExpressionRest java.lang.IllegalStateException: Unable to determine the status of the running process. See the above logs for details

fjtirado pushed a commit to fjtirado/kogito-runtimes that referenced this pull request Jan 10, 2024
…ion (apache#3340)

* [NO ISSUE] Fix Java 17 compilation

* [NO ISSUE] Disable failing test.
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jan 17, 2024
…ion (apache#3340)

* [NO ISSUE] Fix Java 17 compilation

* [NO ISSUE] Disable failing test.
@baldimir baldimir deleted the fix-java-17-compilation branch April 11, 2024 08:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants