Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix_@818] Fixing native python test on Java 17 #3349

Merged
merged 1 commit into from
Jan 15, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Jan 12, 2024

Fixes apache/incubator-kie-issues#818
LD_LIBRARY_PATH should point either to graalvm_home|java_home/server/lib and some extra classes (mainly jdk ones) are needed in the jni set.

@fjtirado fjtirado requested a review from pefernan January 12, 2024 18:17
@fjtirado fjtirado merged commit 7a42795 into apache:main Jan 15, 2024
6 checks passed
@@ -237,6 +238,10 @@
{
"name": "jep.MainInterpreter"
},
{
"name": "jep.PyMethod",
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch! this might be the missing pice in my tests!!

Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@fjtirado great! This fixes the it test.

However it's important to know that the produced binary uses the python installed in the system and LD_LIBRARY_PATH env should be properly set.

rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jan 17, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix kogito-addons-quarkus-serverless-workflow-python addons for native images
2 participants