[Fix_3383] Adding binary cloud event support for outgoing messages #3386
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...odegen-core/src/main/resources/class-templates/config/GlobalObjectMapperQuarkusTemplate.java
Outdated
Show resolved
Hide resolved
This reverts commit 47b9b4d.
fjtirado
changed the title
fjtirado
force-pushed
the
Fix_#3383
branch
2 times, most recently
from
ba86a44 to
aa82aad
Compare
This was referenced Feb 1, 2024
ricardozanini
approved these changes
Feb 2, 2024
@ricardozanini In kogito, it was decided at the beginning to handle the serialization through custom marshallers rather than relying on connector specifics. However, if user want do to that, one of the provided marshallers is a not marshaller at all, which relies on the connector setup |
rgdoliveira
pushed a commit
to rgdoliveira/kogito-runtimes
that referenced
this pull request
Feb 5, 2024
…pache#3386) * [Fix_3383] Do not include null values on json payload * Revert "[Fix_3383] Do not include null values on json payload" This reverts commit 47b9b4d. * [Fix_#3383] Setting metadata when using binary
fjtirado
added a commit
to fjtirado/kogito-runtimes
that referenced
this pull request
Feb 13, 2024
…pache#3386) * [Fix_3383] Do not include null values on json payload * Revert "[Fix_3383] Do not include null values on json payload" This reverts commit 47b9b4d. * [Fix_#3383] Setting metadata when using binary
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Knative has issues with structure event, so we are switching to binary, by defaullt, for quarkus-http connector.
This behaviour can be modified through configuration.
Users can specifiy
kogito.addon.messaging.outgoing.cloudEventMode.<channelName>=BINARY|STRUCTUREDto configure cloud event mode per outgoing channel
or just
kogito.addon.messaging.outgoing.cloudEventMode=BINARY|STRUCTUREDto set it overrall.
If nothing specified, binary is used for quarkus-http connector and structured for the others, to keep backward compatibility with existing examples using Kafka.
This requires changes on kogito-apps tests apache/incubator-kie-kogito-apps#1974 and examples apache/incubator-kie-kogito-examples#1862
Fixes #3383