Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[kie-issues#839] Reproducible build #3393

Merged
merged 7 commits into from
Feb 7, 2024

Conversation

baldimir
Copy link
Contributor

@baldimir baldimir commented Feb 6, 2024

Fixes apache/incubator-kie-issues#839

Changes to make kogito-runtimes build reproducible.

  • Upgrades jandex-maven-plugin, so it generates reproducible index files.
  • Applies similar fix as in Drools and OptaPlanner to remove timestamp comments from generated text files.
    • drools-util is only added as the exec-maven-plugin dependency, not as a normal dependency.
    • First argument of the RemoveCommentsMain class is to ignore non-existing files. This enables to have one common configuration and not individual configurations in modules.

If you want to have a bit of a laugh, check the comment names :) (please squash before merging, if this gets approved)

Copy link
Contributor

@yesamer yesamer left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you @baldimir, well done!

@baldimir baldimir merged commit 0bec946 into apache:main Feb 7, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Mar 11, 2024
@baldimir baldimir deleted the reproducible-build branch April 11, 2024 08:22
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reproducible Build: kogito-runtime repo
3 participants