Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix apache/incubator-kie-issues#987] Fix nightly #3431

Merged
merged 2 commits into from
Mar 8, 2024

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Mar 8, 2024

Fixing IT tests that fails after change

@fjtirado fjtirado requested review from pefernan and nmirasch March 8, 2024 12:05
@fjtirado fjtirado force-pushed the fix_nightly_after_event_changes branch from 3c77e19 to 9469b2a Compare March 8, 2024 13:29
@kie-ci3
Copy link
Contributor

kie-ci3 commented Mar 8, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3431 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3431/1/display/redirect

Test results:

  • PASSED: 2909
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.workflows.WorkflowEventIT.testWorkflowEvents org.opentest4j.AssertionFailedError: expected: but was:

Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 when green

@elguardian elguardian self-requested a review March 8, 2024 14:14
Copy link
Contributor

@elguardian elguardian left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Event Order should stay as it is.

@fjtirado fjtirado requested a review from elguardian March 8, 2024 14:53
@fjtirado fjtirado merged commit 0ff99d1 into apache:main Mar 8, 2024
5 of 6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Mar 11, 2024
fjtirado added a commit to fjtirado/kogito-runtimes that referenced this pull request Apr 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants