Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues#1068] Fix gradle build output #3471

Merged
merged 12 commits into from
Apr 17, 2024

Conversation

gitgabrio
Copy link
Contributor

Fixes apache/incubator-kie-issues#1068

Needs apache/incubator-kie-drools#5839

This PR:

  1. expand the scope of the AppPAths.BuildTool
  2. replace all usages of hardoded directories/paths outside it
  3. enforce the GRADLE-related output paths

Note:
Quarkus define build/classes/java/main as classes dir (vs targer/classes), so this could be a problem with Springboot+gradle (currently untested - still in draft)

How to replicate CI configuration locally?

Build Chain tool does "simple" maven build(s), the builds are just Maven commands, but because the repositories relates and depends on each other and any change in API or class method could affect several of those repositories there is a need to use build-chain tool to handle cross repository builds and be sure that we always use latest version of the code for each repository.

build-chain tool is a build tool which can be used on command line locally or in Github Actions workflow(s), in case you need to change multiple repositories and send multiple dependent pull requests related with a change you can easily reproduce the same build by executing it on Github hosted environment or locally in your development environment. See local execution details to get more information about it.

How to retest this PR or trigger a specific build:
  • for pull request checks
    Please add comment: Jenkins retest this

  • for a specific pull request check
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] tests

  • for quarkus branch checks
    Run checks against Quarkus current used branch
    Please add comment: Jenkins run quarkus-branch

  • for a quarkus branch specific check
    Run checks against Quarkus current used branch
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-branch

  • for quarkus main checks
    Run checks against Quarkus main branch
    Please add comment: Jenkins run quarkus-main

  • for a specific quarkus main check
    Run checks against Quarkus main branch
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-main

  • for quarkus lts checks
    Run checks against Quarkus lts branch
    Please add comment: Jenkins run quarkus-lts

  • for a specific quarkus lts check
    Run checks against Quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] quarkus-lts

  • for native checks
    Run native checks
    Please add comment: Jenkins run native

  • for a specific native check
    Run native checks
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native

  • for native lts checks
    Run native checks against quarkus lts branch
    Please add comment: Jenkins run native-lts

  • for a specific native lts check
    Run native checks against quarkus lts branch
    Please add comment: Jenkins (re)run [kogito-runtimes|kogito-apps|kogito-examples] native-lts

How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Quarkus-3 PR check is failing ... what to do ? The Quarkus 3 check is applying patches from the `.ci/environments/quarkus-3/patches`.

The first patch, called 0001_before_sh.patch, is generated from Openrewrite .ci/environments/quarkus-3/quarkus3.yml recipe. The patch is created to speed up the check. But it may be that some changes in the PR broke this patch.
No panic, there is an easy way to regenerate it. You just need to comment on the PR:

jenkins rewrite quarkus-3

and it should, after some minutes (~20/30min) apply a commit on the PR with the patch regenerated.

Other patches were generated manually. If any of it fails, you will need to manually update it... and push your changes.

String expectedPath = String.format("%s/%s/generated-resources", projectDirPath, outputTargetPath).replace("/", File.separator);
assertTrue(retrieved.contains(Path.of(expectedPath)));
}
// @ParameterizedTest
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm not understanding why you added these tests (which looks ok) but you commented them out. Are you still working on this?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, still working on that.
My plan is to extend test coverage to the places I modified (where possible)

@gitgabrio gitgabrio marked this pull request as ready for review April 15, 2024 13:22
@gitgabrio
Copy link
Contributor Author

Jenkins retest this

Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@gitgabrio
Copy link
Contributor Author

Failure seems unrelated to PR itself:

  1. the full downstream build from upstream PR succeeded
  2. the jenkins build succeeded
  3. I re-executed the build chain locally, and it succeeded
  4. the failure is related to ClassNotFoundException for org.kie.kogito.codegen.core.utils.GeneratedFileWriter$Builder , but this class has been deleted by my PR and I could not find any reference to it

@rodrigonull @jstastny-cz Could you please look at that, or involve someone who could take a look? Thanks!

@gitgabrio gitgabrio merged commit a795aac into apache:main Apr 17, 2024
5 of 6 checks passed
@gitgabrio gitgabrio deleted the incubator-kie-issues#1068 branch April 17, 2024 08:36
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Apr 23, 2024
* [test-gradle-target] WIP

* [incubator-kie-issues#1068] Enhancing dual build-system management. Locally working

* [incubator-kie-issues#1068] Fix classes path for multimodule project

* [incubator-kie-issues#1068] Restored kogito.codegen.sources.directory usage. Unified GeneratedFileWriter instantiation and usage

* [incubator-kie-issues#1068] REmove duplicated class. REstored test

* [incubator-kie-issues#1068] Remove unused parameter

* [incubator-kie-issues#1068] Fixed formatting

* [incubator-kie-issues#1068] Fixed formatting

---------

Co-authored-by: Gabriele-Cardosi <gabriele.cardosi@ibm.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Fix gradle build output
6 participants