Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito. #3478

Merged
merged 4 commits into from
Apr 27, 2024

Conversation

elguardian
Copy link
Contributor

issue: apache/incubator-kie-issues#1103

move tests and bpmn2 compilation of v7 legacy runtime. the goal is not affect the current status of tests while allow working on migrating tests and features.

@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 22, 2024

PR job #1 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3478 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3478/1/display/redirect

Test results:

  • PASSED: 3260
  • FAILED: 1

Those are the test failures:

org.kie.kogito.quarkus.jbpm.OrdersProcessIT.testOrdersRest 1 expectation failed.
Expected status code <201> but was <500>.

@elguardian elguardian force-pushed the incubator-kie-issues-1103 branch from b3196b0 to 7799408 Compare April 22, 2024 14:24
@elguardian elguardian requested a review from porcelli April 23, 2024 14:14
Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

great move @elguardian - just minor comment.

import org.kie.kogito.process.bpmn2.BpmnVariables;
import org.kie.kogito.process.impl.AbstractProcess;

public class XXX extends AbstractProcess<Model> {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

XXXX?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

it is just a template. so it does not really matter, it could be whatever

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

what about: ThisIsJustTemplate or something like?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced

@@ -0,0 +1,29 @@
<?xml version="1.0" encoding="UTF-8"?>
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

is this file needed?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yep

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

usually bak file are auto generated on save by some editors... maybe clarify that this is not the case somewhere

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

removed

kogito-build/kogito-dependencies-bom/pom.xml Show resolved Hide resolved
@elguardian elguardian requested a review from porcelli April 26, 2024 06:18
Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

missing few updates, other than that.. looks good



public static org.kie.kogito.process.Process<Model> newProcess(Application application) {
return new XXX(application.config().get(ProcessConfig.class), application);
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThisIsJustTemplate update missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced

return new XXX(application.config().get(ProcessConfig.class), application);
}

public XXX(ProcessConfig processConfig, Application application) {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ThisIsJustTemplate update missing

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

replaced

Copy link
Member

@porcelli porcelli left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thx! this is very good, thank you again @elguardian

@elguardian elguardian force-pushed the incubator-kie-issues-1103 branch from 8d03c15 to e53fdf2 Compare April 27, 2024 06:37
@elguardian elguardian merged commit a52ea3a into apache:main Apr 27, 2024
6 checks passed
@elguardian elguardian deleted the incubator-kie-issues-1103 branch April 27, 2024 10:22
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request May 7, 2024
…ove old legacy v7 tests to kogito. (apache#3478)

* [incubator-kie-issues-1103] Move tests and create infrastructure to move old legacy v7 tests to kogito.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Move tests and create infrastructure to move old legacy v7 tests to kogito.
4 participants