Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix #3480] Changing jsonb to varchar #3484

Merged
merged 2 commits into from
Apr 26, 2024
Merged

Conversation

fjtirado
Copy link
Contributor

@fjtirado fjtirado commented Apr 23, 2024

Fixes #3480

@fjtirado fjtirado requested review from nmirasch and gmunozfe April 23, 2024 12:14
@fjtirado fjtirado force-pushed the Fix_#3469 branch 6 times, most recently from 83fb6b5 to 3b8e60f Compare April 23, 2024 15:16
@kie-ci3
Copy link
Contributor

kie-ci3 commented Apr 23, 2024

PR job #7 was: UNSTABLE
Possible explanation: This should be test failures

Reproducer

build-chain build full_downstream -f 'https://raw.githubusercontent.com/${AUTHOR:apache}/incubator-kie-kogito-pipelines/${BRANCH:main}/.ci/buildchain-config-pr-cdb.yaml' -o 'bc' -p apache/incubator-kie-kogito-runtimes -u #3484 --skipParallelCheckout

NOTE: To install the build-chain tool, please refer to https://github.com/kiegroup/github-action-build-chain#local-execution

Please look here: https://ci-builds.apache.org/job/KIE/job/kogito/job/main/job/pullrequest_jobs/job/kogito-runtimes-pr/job/PR-3484/7/display/redirect

Test results:

  • PASSED: 2867
  • FAILED: 1

Those are the test failures:

org.kie.kogito.mongodb.transaction.AbstractTransactionManagerIT.testAbort Command failed with error 246 (SnapshotUnavailable): 'Unable to read from a snapshot due to pending collection catalog changes; please retry the operation. Snapshot timestamp is Timestamp(1713883869, 0). Collection minimum is Timestamp(1713883869, 2)' on server 172.18.0.1:32799. The full response is {"errorLabels": ["TransientTransactionError"], "operationTime": {"$timestamp": {"t": 1713883868, "i": 6}}, "ok": 0.0, "errmsg": "Unable to read from a snapshot due to pending collection catalog changes; please retry the operation. Snapshot timestamp is Timestamp(1713883869, 0). Collection minimum is Timestamp(1713883869, 2)", "code": 246, "codeName": "SnapshotUnavailable", "$clusterTime": {"clusterTime": {"$timestamp": {"t": 1713883869, "i": 3}}, "signature": {"hash": {"$binary": {"base64": "AAAAAAAAAAAAAAAAAAAAAAAAAAA=", "subType": "00"}}, "keyId": 0}}}

@deepakkapoor23
Copy link

This doesn't really address #3469, only affects JDBC persistence...but that's enough for my use case right now. Thanks @fjtirado

@fjtirado
Copy link
Contributor Author

This doesn't really address #3469, only affects JDBC persistence...but that's enough for my use case right now. Thanks @fjtirado

You are right, MongoDB is not relational ;)

@fjtirado fjtirado changed the title [Fix #3469 Fix #3480] Changing jsonb to varchar [Fix #3480] Changing jsonb to varchar Apr 24, 2024
Copy link
Contributor

@gmunozfe gmunozfe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me, well done @fjtirado !

@fjtirado fjtirado merged commit 1601ca4 into apache:main Apr 26, 2024
6 checks passed
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request May 7, 2024
* [Fix apache#3469 Fix apache#3480] Changing jsonb to varchar

* [Fix apache#3480]  Change blob to varbinary for ansi
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

add correlation persistence support for mssql
5 participants