Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[incubator-kie-isssues-1139] Add support for xpath in conditional paths #3493

Merged
merged 2 commits into from
May 15, 2024

Conversation

elguardian
Copy link
Contributor

Copy link
Contributor

@martinweiler martinweiler left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@elguardian elguardian force-pushed the incubator-kie-issues-1139 branch from ef3894a to b53aaa9 Compare May 13, 2024 06:58
@pefernan
Copy link
Contributor

@elguardian From the engine side everything seems to work fine but I found an issue while testing the example in this PR inside a kogito app. Looks like there's a problem when generating the Kogito Persistence when the process variable type is org.w3c.dom.Document. The stack trace says:

java.lang.RuntimeException: io.quarkus.builder.BuildException: Build failure: Build failed due to errors
	[error]: Build step org.kie.kogito.quarkus.processes.deployment.ProcessesAssetsProcessor#postGenerationProcessing threw an exception: java.lang.RuntimeException: Error while generating proto for model class 
org.kie.kogito.hr.XPathProcessModel Custom type org.w3c.dom.Document is no supported by Kogito persistence, please consider using a class that extends java.io.Serializable and contains a no arg constructor

Additionally I couldn't make it work when the process uses a Pojo as variable, but I think we can fix this second scenario in a later improvement.

@apache apache deleted a comment from kie-ci3 May 13, 2024
@elguardian elguardian force-pushed the incubator-kie-issues-1139 branch from b53aaa9 to c4a2a6b Compare May 14, 2024 07:06
@elguardian
Copy link
Contributor Author

@pefernan I will take care of the issue in the persistence stuff
apache/incubator-kie-issues#1204

@apache apache deleted a comment from kie-ci3 May 14, 2024
Copy link
Contributor

@pefernan pefernan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

+1 Let's tackle the persistence in a new task.

@elguardian elguardian requested a review from pefernan May 15, 2024 09:14
@elguardian elguardian merged commit e53d706 into apache:main May 15, 2024
6 checks passed
@elguardian elguardian deleted the incubator-kie-issues-1139 branch May 15, 2024 09:15
rgdoliveira pushed a commit to rgdoliveira/kogito-runtimes that referenced this pull request Jun 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add support for xpath in conditional paths
3 participants