Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Splitting e2e tests; add custom config to use quay #499

Draft
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ricardozanini
Copy link
Member

Description of the change:

Motivation for the change:

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that tall the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Signed-off-by: Ricardo Zanini <zanini@redhat.com>
@ricardozanini
Copy link
Member Author

@wmedvede can you take a look at this? I spotted here a problem where we create a default SonataFlowPlatform and have a custom sonataflowBuilderImage in the controller config, it won't take the FROM clause from there, but from the default Dockerfile.

I couldn't fix it in time for my PTO. A user might report this in the product/usage. A workaround is just deleting the SonataFlowBuild, the respin will take the configuration ok. The problem is a race condition between the creation of the default platform and the first build of the workflow. That's my guess, I didn't have the time to debug it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant