Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

NO-ISSUE: Fix image names in CI and the script to bump versions #500

Merged

Conversation

rodrigonull
Copy link
Contributor

Fixes image names on CI after the migration to dockerhub and also fixes the script to bump the project version.

@rodrigonull
Copy link
Contributor Author

@ricardozanini @wmedvede Can you help us verify what could be causing the E2E tests failure?

@ricardozanini
Copy link
Member

@rodrigonull are the docker.io images published?

@rodrigonull
Copy link
Contributor Author

@tiagobento
Copy link

tiagobento commented Jun 28, 2024

Is this repo part of any of our automations? I'm afraid this can cause some unwanted interference with sonataflow-operator currently on on kie-tools during the 10.0.0 release.

@rodrigonull
Copy link
Contributor Author

Is this repo part of any of our automations? I'm afraid this can cause some unwanted interference with sonataflow-operator currently on on kie-tools during the 10.0.0 release.

Yes, the nightly job is still running. I guess we need to disable it until we release 10? Or we can just disable image publishing. That is an option too.

@tiagobento
Copy link

Yeah, IDK, I think we shouldn't be publishing anything out of this repo before Apache KIE 10...

@tiagobento
Copy link

And after Apache KIE 10, we need to decide what to do...

@ricardozanini
Copy link
Member

After 10.x the image publishing must be done from this repo.

@ricardozanini
Copy link
Member

ricardozanini commented Aug 6, 2024

@rodrigonull can you force push to run the CI again?

@tiagobento
Copy link

@ricardozanini Not sure why. As far as I can tell, we never agreed on moving the kogito-swf-builder and kogito-swf-devmode images from kogito-images to kogito-serverless-operator.

@ricardozanini
Copy link
Member

@tiagobento lol, yes I meant kogito-image. I thought I was there.

@ricardozanini
Copy link
Member

@rodrigonull, have you rebased this branch? I'm asking because I recently opened a PR, and e2e works perfectly.

@rodrigonull rodrigonull force-pushed the kogito-serverless-operator-ci-fixes branch from 021df7a to 2c41efb Compare August 8, 2024 13:02
@rodrigonull
Copy link
Contributor Author

@ricardozanini Rebased. All green now :)

@ricardozanini ricardozanini merged commit 2abeb9e into apache:main Aug 8, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants