Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix #504 - Build images before running e2e #546

Merged
merged 2 commits into from
Oct 4, 2024

Conversation

ricardozanini
Copy link
Member

@ricardozanini ricardozanini commented Oct 3, 2024

Description of the change:
Fix #504

In this PR:

  • E2E won't deploy SonataFlow objects in preview profile anymore. Everything should be gitops to reuse the images built before firing up the test suites.
  • Moved all the e2e use cases to test/e2e/testdata

Motivation for the change:
E2E is taking too long to execute, mainly the platform use case. This change saves around 10 minutes to run the platform use case. Another gain was from the flows-persistence use cases, around 5 minutes.

Checklist

  • Add or Modify a unit test for your change
  • Have you verified that all the tests are passing?
How to backport a pull request to a different branch?

In order to automatically create a backporting pull request please add one or more labels having the following format backport-<branch-name>, where <branch-name> is the name of the branch where the pull request must be backported to (e.g., backport-7.67.x to backport the original PR to the 7.67.x branch).

NOTE: backporting is an action aiming to move a change (usually a commit) from a branch (usually the main one) to another one, which is generally referring to a still maintained release branch. Keeping it simple: it is about to move a specific change or a set of them from one branch to another.

Once the original pull request is successfully merged, the automated action will create one backporting pull request per each label (with the previous format) that has been added.

If something goes wrong, the author will be notified and at this point a manual backporting is needed.

NOTE: this automated backporting is triggered whenever a pull request on main branch is labeled or closed, but both conditions must be satisfied to get the new PR created.

Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
Signed-off-by: Ricardo Zanini <ricardozanini@gmail.com>
@ricardozanini ricardozanini merged commit 7bfc6e5 into apache:main Oct 4, 2024
5 checks passed
@ricardozanini ricardozanini deleted the issue-504 branch October 4, 2024 13:11
rgdoliveira pushed a commit to rgdoliveira/kogito-serverless-operator that referenced this pull request Oct 24, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Create incubator-kie-sonataflow-minimal-example image for the gitops test
3 participants