-
Notifications
You must be signed in to change notification settings - Fork 190
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
kie-issues#1040: Remove packages/sonataflow-images and packages/sonataflow-operator from kie-tools #2472
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you @thiagoelg for your prompt action following thru the agreed 10 release proposal [1]
[1] https://lists.apache.org/thread/pw327lkpmy9gxklq4t5zbwzxjo2y3c0w
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@porcelli , @thiagoelg Guys, this removal must be coordinated with the move of this bits to their new destination in apache/incubator-kie-kogito-serverless-operator. We can't remove this as is.
@ricardozanini will execute this move to apache/incubator-kie-kogito-serverless-operator when he's back in two weeks. Until this, we must hold-on this PR.
@wmedvede I'm not sure what needs to be coordinated... this PR will only accomplish what has been long time decided. AFAIK, the original repos from where the content had to be moved never stop the development... so I can't see why hold this change |
@porcelli But, for example incubator-kie-sonataflow-builder, is based on bits from kie-kogito-runtimes. If we stop producing incubator-kie-sonataflow-builder from one day to the other, we'll have that image outdated with reference to kie-kogito-runtimes. This represent something no good for the us. (example, if we need to do a fix in kogito-runtimes, we won't have this fix reflected in incubator-kie-sonataflow-builder) On the other hand, considering that the CI for incubator-kie-sonataflow-builder is already set, and this image is already being being produced regularly, I don't think this represents a problem nor any extra work. |
@wmedvede We have the discussions going on the Mailing List (https://lists.apache.org/thread/ldb45nljq2q2d8pln3bxmh4g0m6k7o6l), but it was agreed that we would do this even if that broke stuff. Anyway, please let's continue the conversations on the email thread. |
Part of apache/incubator-kie-issues#1040
ENV
definitions with deprecated syntaxes (unrelated, but noticed some warnings about the deprecation)