Skip to content

Commit

Permalink
[NEMO-379] Change javadoc goal to a proper one
Browse files Browse the repository at this point in the history
JIRA: [NEMO-379: Change javadoc goal to a proper one](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-379)

**Major changes:**
- Change javadoc test command from `javadoc` to `test-javadoc`. This prevents tests from creating unwanted javdoc files, caused by #139 .

**Minor changes to note:**
- None

**Tests for the changes:**
- None

**Other comments:**
- None

Closes #212
  • Loading branch information
wonook authored and taegeonum committed Apr 15, 2019
1 parent 6eea2aa commit 66c2d92
Show file tree
Hide file tree
Showing 9 changed files with 51 additions and 7 deletions.
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@
/**
* Test output collector that collects data and watermarks.
*
* @param <T>
* @param <T> type of the output.
*/
final class TestOutputCollector<T> implements OutputCollector<WindowedValue<T>> {
public final List<WindowedValue<T>> outputs;
Expand Down
2 changes: 1 addition & 1 deletion pom.xml
Original file line number Diff line number Diff line change
Expand Up @@ -285,7 +285,7 @@ under the License.
<execution>
<id>test-javadoc</id>
<goals>
<goal>javadoc</goal>
<goal>test-javadoc</goal>
</goals>
<phase>validate</phase>
</execution>
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -115,6 +115,8 @@ private String getTaskId(final int index) {

/**
* Generates the ids and the data which will be used for the block store tests.
*
* @throws Exception exception on the way.
*/
@Before
public void setUp() throws Exception {
Expand Down Expand Up @@ -220,6 +222,8 @@ public void setUp() throws Exception {

/**
* Test {@link MemoryStore}.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testMemoryStore() throws Exception {
Expand All @@ -233,6 +237,8 @@ public void testMemoryStore() throws Exception {

/**
* Test {@link SerializedMemoryStore}.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testSerMemoryStore() throws Exception {
Expand All @@ -246,6 +252,8 @@ public void testSerMemoryStore() throws Exception {

/**
* Test {@link LocalFileStore}.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testLocalFileStore() throws Exception {
Expand All @@ -265,6 +273,8 @@ public void testLocalFileStore() throws Exception {
* Test {@link GlusterFileStore}.
* Actually, we cannot create a virtual GFS volume in here.
* Instead, this test mimics the GFS circumstances by doing the read and write on separate file stores.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testGlusterFileStore() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -45,6 +45,8 @@ public final class BlockTest {

/**
* Generates the test data and serializer.
*
* @throws Exception exception on the way.
*/
@Before
public void setUp() throws Exception {
Expand All @@ -62,6 +64,8 @@ public void setUp() throws Exception {

/**
* Test {@link NonSerializedMemoryBlock}.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testNonSerializedMemoryBlock() throws Exception {
Expand All @@ -71,6 +75,8 @@ public void testNonSerializedMemoryBlock() throws Exception {

/**
* Test {@link org.apache.nemo.runtime.executor.data.block.SerializedMemoryBlock}.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testSerializedMemoryBlock() throws Exception {
Expand All @@ -80,6 +86,8 @@ public void testSerializedMemoryBlock() throws Exception {

/**
* Test {@link FileBlock}.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testFileBlock() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -135,6 +135,8 @@ private boolean checkEqualElements(final List<Integer> left, final List<Integer>

/**
* Test source vertex data fetching.
*
* @throws Exception exception on the way.
*/
@Test()
public void testSourceVertexDataFetching() throws Exception {
Expand Down Expand Up @@ -191,6 +193,8 @@ public void close() throws IOException {

/**
* Test invalid parameter failure.
*
* @throws Exception exception on the way.
*/
@Test()
public void testInvalidInputData() throws Exception {
Expand All @@ -208,6 +212,8 @@ public void testInvalidInputData() throws Exception {

/**
* This test emits data and watermark by emulating an unbounded source readable.
*
* @throws Exception exception on the way.
*/
@Test()
public void testUnboundedSourceVertexDataFetching() throws Exception {
Expand Down Expand Up @@ -255,6 +261,8 @@ public void testUnboundedSourceVertexDataFetching() throws Exception {

/**
* Test parent task data fetching.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 5000)
public void testParentTaskDataFetching() throws Exception {
Expand Down Expand Up @@ -294,8 +302,8 @@ private void waitUntilWatermarkEmitted(final Queue<Long> watermarkQueue) {

/**
* The DAG of the task to test will looks like:
* source1 -> vertex1 -> vertex2
* source2 -> vertex3 ->
* source1 - vertex1 - vertex2
* source2 - vertex3 -
* <p>
* The vertex2 has two incoming edges (from vertex1 and vertex3)
* and we test if TaskExecutor handles data and watermarks correctly in this situation.
Expand All @@ -304,6 +312,8 @@ private void waitUntilWatermarkEmitted(final Queue<Long> watermarkQueue) {
* source2 emits watermarks: 1000(ts) 2200 (ts)
* <p>
* The vertex2 should receive and emits watermarks 500, 600, 1000, 1800, and 2200
*
* @throws Exception exception on the way.
*/
@Test()
public void testMultipleIncomingEdges() throws Exception {
Expand Down Expand Up @@ -386,11 +396,13 @@ public void run() {

/**
* The DAG of the task to test will looks like:
* parent task -> task (vertex 1 -> task 2) -> child task
* parent task - task (vertex 1 - task 2) - child task
* <p>
* The output data from task 1 will be split according to source parallelism through {@link ParentTaskReaderAnswer}.
* Because of this, task 1 will process multiple partitions and emit data in multiple times also.
* On the other hand, task 2 will receive the output data once and produce a single output.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 5000)
public void testTwoOperators() throws Exception {
Expand Down Expand Up @@ -470,6 +482,8 @@ public void testTwoOperatorsWithBroadcastVariable() {
* <p>
* emit(element) and emit(dstVertexId, element) used together. emit(element) routes results to main output children,
* and emit(dstVertexId, element) routes results to corresponding additional output children.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 5000)
public void testAdditionalOutputs() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -81,7 +81,7 @@ private static void checkPendingFuture(final Future<String> future) {
/**
* Test scenario where block becomes committed and then lost.
*
* @throws Exception
* @throws Exception exception on the way.
*/
@Test
public void testLostAfterCommit() throws Exception {
Expand Down Expand Up @@ -112,7 +112,7 @@ public void testLostAfterCommit() throws Exception {
/**
* Test scenario where producer task fails.
*
* @throws Exception
* @throws Exception exception on the way.
*/
@Test
public void testBeforeAfterCommit() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -66,6 +66,8 @@ public void setUp() throws Exception {
/**
* This method builds a physical DAG starting from an IR DAG and submits it to {@link PlanStateManager}.
* State changes are explicitly called to check whether states are managed correctly or not.
*
* @throws Exception exception on the way.
*/
@Test
public void testPhysicalPlanStateChanges() throws Exception {
Expand Down Expand Up @@ -97,6 +99,8 @@ public void testPhysicalPlanStateChanges() throws Exception {

/**
* Test whether the methods waiting for the finish of the plan works properly.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 4000)
public void testWaitUntilFinish() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -119,6 +119,8 @@ public void setUp() throws Exception {
/**
* This method builds a physical DAG starting from an IR DAG and submits it to {@link BatchScheduler}.
* Task state changes are explicitly submitted to scheduler instead of executor messages.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testPull() throws Exception {
Expand All @@ -129,6 +131,8 @@ public void testPull() throws Exception {
/**
* This method builds a physical DAG starting from an IR DAG and submits it to {@link BatchScheduler}.
* Task state changes are explicitly submitted to scheduler instead of executor messages.
*
* @throws Exception exception on the way.
*/
@Test(timeout = 10000)
public void testPush() throws Exception {
Expand Down
Original file line number Diff line number Diff line change
Expand Up @@ -67,6 +67,8 @@ public void setUp() throws Exception {
/**
* {@link LocalitySchedulingConstraint} should fail to schedule a {@link Task} when
* there are no executors in appropriate location(s).
*
* @throws InjectionException exception on the way.
*/
@Test
public void testSourceLocationAwareSchedulingNotAvailable() throws InjectionException {
Expand All @@ -87,6 +89,8 @@ public void testSourceLocationAwareSchedulingNotAvailable() throws InjectionExce
/**
* {@link LocalitySchedulingConstraint} should properly schedule {@link Task}s
* with multiple source locations.
*
* @throws InjectionException exception on the way.
*/
@Test
public void testSourceLocationAwareSchedulingWithMultiSource() throws InjectionException {
Expand Down

0 comments on commit 66c2d92

Please sign in to comment.