Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEMO-391] Set GrpcMessageEnvironment as a default implementation #218

Merged
merged 3 commits into from
Jun 10, 2019

Conversation

taegeonum
Copy link
Contributor

JIRA: NEMO-391: Set GrpcMessageEnvironment as a default implementation

Major changes:

  • Change the default implementation of MessageEnvironment to GrpcMessageEnvironment

Copy link
Contributor

@johnyangk johnyangk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. I like grpc.

@johnyangk johnyangk merged commit 639335f into apache:master Jun 10, 2019
alapha23 pushed a commit to alapha23/incubator-nemo that referenced this pull request Aug 2, 2019
…ache#218)

JIRA: [NEMO-391: Set GrpcMessageEnvironment as a default implementation](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-391)

**Major changes:**
- Change the default implementation of MessageEnvironment to GrpcMessageEnvironment

foo

wordIO works but metrics fail
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants