Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[NEMO-413] Fix index checking for byte access of MemoryChunk using UNSAFE #234

Merged
merged 2 commits into from
Aug 19, 2019

Conversation

hy00nc
Copy link
Member

@hy00nc hy00nc commented Aug 19, 2019

JIRA: NEMO-413: Fix index checking for byte access of MemoryChunk using UNSAFE

Major changes:

  • Index checking for byte operation using UNSAFE fixed: type size for byte changed from 0 to 1.

@DifferentSC
Copy link
Contributor

@hy00nc Could you please merge this PR with the updated master and push the merged branch again? Thanks!

Copy link
Contributor

@DifferentSC DifferentSC left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for me. I will merge this PR.

@DifferentSC DifferentSC merged commit cb75680 into apache:master Aug 19, 2019
wonook pushed a commit to snuspl/incubator-nemo that referenced this pull request Sep 7, 2019
…SAFE apache#234

JIRA: [NEMO-413: Fix index checking for byte access of MemoryChunk using UNSAFE](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-413)

**Major changes:**
- Index checking for byte operation using UNSAFE fixed: type size for byte changed from 0 to 1.

Closes apache#234
wonook pushed a commit to snuspl/incubator-nemo that referenced this pull request Sep 7, 2019
…SAFE apache#234

JIRA: [NEMO-413: Fix index checking for byte access of MemoryChunk using UNSAFE](https://issues.apache.org/jira/projects/NEMO/issues/NEMO-413)

**Major changes:**
- Index checking for byte operation using UNSAFE fixed: type size for byte changed from 0 to 1.

Closes apache#234
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants