Release 2.5.0 #38
Merged
Release 2.5.0 #38
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acelyc111
reviewed
Dec 11, 2023
_docs/en/2.5.0/compile-by-docker.md
Outdated
|
|
||
| ```bash | ||
| docker run -v /your/local/apache-pegasus-source:/root/pegasus \ | ||
| apache/pegasus:build-env-ubuntu2004 \ |
There was a problem hiding this comment.
Is there an image specified for 2.5.0? Because the images might have been updated(remove some packages), it may cause build failures.
There was a problem hiding this comment.
Good advice! I think we could modify build-push-env-docker.yml to support build-env-* images for different branches, such as master, v2.5.0, etc.
|
Building build-env-* images for different branches have been supported by: |
acelyc111
approved these changes
Dec 12, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since version 2.5.0 has been released, we could add docs for 2.5.0 for official website, such as download links and building commands: